Project

General

Profile

Actions

Bug #22683

closed

External links are prepended with current domain

Added by Dmitry Dulepov over 14 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-05-19
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Assuming you are on the localhost, enter external link as http://something/?id=3. t3lib_parsehtml_proc will convert it to http://localhost/http://something/?id=3 when fetching from db back to RTE. The look of external URL is essential for this bug.

(issue imported from #M14436)


Files

14436-4.2.diff (1.93 KB) 14436-4.2.diff Administrator Admin, 2010-05-19 19:29
14436-trunk.diff (1.93 KB) 14436-trunk.diff Administrator Admin, 2010-05-19 19:29
typo3core_bugfix_14436_trunk.patch (2.23 KB) typo3core_bugfix_14436_trunk.patch Administrator Admin, 2010-06-02 16:00
typo3core_bugfix_14436_typo3_4-3.patch (2.23 KB) typo3core_bugfix_14436_typo3_4-3.patch Administrator Admin, 2010-06-17 16:49

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #23202: Bogus values added to Links (related: bug 14436) and after applying patch 14436: rte does not start at all (related: 15068?)ClosedStanislas Rolland2010-07-16

Actions
Has duplicate TYPO3 Core - Bug #23275: RTE html Area link problemClosedStanislas Rolland2010-07-27

Actions
Actions #1

Updated by Stanislas Rolland over 14 years ago

Hi Dmitry,

You get this behaviour when the domain "something" does not contain any dot?

Do you get the same behaviour when the domain name contains at least one dot?

Actions #2

Updated by Dmitry Dulepov over 14 years ago

Hi Stanislas!

Actually, both cases. The bug was first discovered for one of major Snowflake's customers. They had domains like 'aaa.bbb.ccc'. Then I reproduced it in my local testing environment. Locally I use short domain names like 't3test', 't3trunk' and so on. I did the patch, which we applied to get rid of this problem.

Do you see any problems with my patch? I'd be happy to adjust it as necessary.

Actions #3

Updated by Stanislas Rolland over 14 years ago

Hi Dmitry,

I think that if the url is not an email, nor a local file, then if it contains a scheme, it should be considered external.

Please test the attached patch against current trunk (TYPO3 4.4 beta3+).

Actions #4

Updated by Stanislas Rolland over 14 years ago

Hi Dmitry,

Did you try the attached patch in your environment?

Actions #5

Updated by Dmitry Dulepov over 14 years ago

Hi Stan! I do not get mail notifications from Mantis for some reason, so I did not see your questions. Sorry about that.

Yes, the patch helps! I was able to reproduce the issue. After applying the patch it is gone. Thank you very much!

Actions #6

Updated by Stanislas Rolland over 14 years ago

Hi Dmitry,

Please give your +1 in the core list.

Actions #7

Updated by Stanislas Rolland over 14 years ago

Committed to SVN TYPO3core trunk (revision 7960) and branch TYPO3_4-3 (revision 7961).

Actions #8

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF