TYPO3 Core

patch useless, forgot some essential code... sorry

sorry for the confusion, it's my very first bugfix to the core :-)
15034v3.patch should correctly recognize both IPv4 and IPv6 for TYPO3_HOST_ONLY and TYPO3_PORT
includes revised unit test in 15034v3_UnitTest.patch

Regarding the test:
Could you use 2 dataproviders instead a bunch of asserts?

@Nikolas Hagelstein thanks for pointing that out
uploaded 15034v5_UnitTest.patch using dataProvider

Thanks for your patch, Roland!

• Space after "," as argument separator is sometimes missing

self::getIndpEnv('HTTP_HOST'),']:')

should be

self::getIndpEnv('HTTP_HOST'), ']:')

• Comments should be intended by one Tab

I'm unsure, how to handle according to CGL

}
// blabla
else {

Please remove the commented out lines:

+ //$p = explode(':',self::getIndpEnv('HTTP_HOST'));
+ //$retVal = $p⁰;

Updated patch attached.
Think you should send it to the Core list!

thanks Steffen Gebert!
posted to core list and tagged as "pending in core list"

15034_v5.diff contains a better aproach with less code

15034_v6.diff removed 2 CGL issues
big thanks to Caspar!

15034_v7.diff with the latest recommendations from the core list
and improved human readability for the unit test

• trunk rev. 9971
• 4.4 rev. 9972
• 4.3 rev. 9973