TYPO3 Core

A better look at the code gave an other idea:

we are passing numeric values to the strpos function, which expect strings.
if the value matches the charcode of ',', we get a false positive.

can be tested with the following in t3lib_DivTest.php:
/** * @test
*/
public function checkStrposWithIntegers() {

$testarray = array(ord(','),10,20);
        $checkarray = array(',',',',',');
        $expectedArray = array(false, false,false );
        $actualArray = array_map(strpos,$checkarray,$testarray);

$this->assertEquals($expectedArray, $actualArray);
    }

possible fixes:
1) run the value through stringval in t3lib_db->listquery if it is not a string
2) only pass strings to t3lib_db->listquery
3) check for comma only for strings.

my prefered solution would be 1.

the following testcase runs clean:

public function checkStrposWithIntegers2() {

$testarray = array(ord(','),10,20);
        $checkarray = array(',',',',',');
        $expectedArray = array(false, false,false );
        $testarray2=array_map(strval,$testarray);
        $actualArray = array_map(strpos,$checkarray,$testarray2);

$this->assertEquals($expectedArray, $actualArray);
    }

Commited v2.diff to trunk (rev. 8259)