Project

General

Profile

Actions

Bug #23568

closed

BE input validation "time" rejects 0:00 and 24:00

Added by Stephan Schuler about 14 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2010-09-20
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.2
PHP Version:
4.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When an input field "type text" is defined as "eval time", the automated time evaluation function rejects the values "0:00" by setting it to empty and rejects "24:00" by resetting the input to "23:00".

Refering to revision 8823 of https://svn.typo3.org/TYPO3v4/Core/branches/TYPO3_4-2/t3lib/jsfunc.evalfield.js

Line 421 says:
if (hours > 23) {hours = 23};

Line 454 says:
if (!parseInt(value)) {return '';}

Those lines conflict because the first one excludes the hour 24 (no matter what minutes are concernted) and the second one excludes the explicite 0:00 (or 0:00:00 when eval is timesec instead of time).

Without having it tested, this bug should exist on 4.3 and 4.4 as well because the mentioned code is pretty much the same there.

(issue imported from #M15748)


Files

15748_v1.patch (639 Bytes) 15748_v1.patch Administrator Admin, 2010-09-24 18:58

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #23610: can't insert 0:00 to BE time input fieldClosed2010-09-25

Actions
Actions #1

Updated by Lars Malach about 14 years ago

This patch fixes just the first problem with 24 hour.

The second problem should be a bigger typo3 task, because typo3 is not able to differ 0 and Null.

Actions #2

Updated by Steffen Gebert about 14 years ago

committed to
- trunk rev. 8883
- 4-4 rev. 8884
- 4-3 rev. 8885

Please open up a new report for the other problem.

Actions #3

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF