Project

General

Profile

Actions

Feature #23688

closed

Replace the current if-construct of stdWrap with real functions and make each of them stdWrap aware

Added by Jo Hasenau about 14 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Category:
Communication
Target version:
-
Start date:
2010-10-07
Due date:
% Done:

0%

Estimated time:
PHP Version:
5.2
Tags:
Complexity:
Sprint Focus:

Description

As we decided during the "Pimp my TS" workshop at T3DD10 and as announced at T3CON, the attached patch will do the following:

1. Remove the serialized if clauses from the function stdWrap
2. Replace them with real functions called in the correct order to stay backwards compatible
3. Make each of the functions stdWrap aware
4. Still take care of the 4 hooks currently available in function stdWrap

Exceptions for 3:

cObject and the recursive stdWrap call will not use nested stdWrap functions, since these are the only functions using stdWrap functions on the real content, while all others will apply stdWrap functions to the value of the property itself

preUserFunc, postUserFunc and postUserFuncInt are excluded form nested stdWrap as well to avoid conflicts with individual markup used within those functions

I made some tests with default CSS-styled-content elements and everything seems to be running quite well. Admin Panel shows that the new version seems to be a bit faster than the original, although the nested function call is already implemented.

(issue imported from #M15928)


Files

stdWrap.diff (75.4 KB) stdWrap.diff Administrator Admin, 2010-10-07 18:42
stdWrap_v2.diff (75.2 KB) stdWrap_v2.diff Administrator Admin, 2010-10-07 19:59
stdWrap_v3.diff (75.2 KB) stdWrap_v3.diff Administrator Admin, 2010-10-07 20:00

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #24977: Extension using stdWrap hooks are broken due to stdWrap refactoringClosedJigal van Hemert2011-02-07

Actions
Actions #1

Updated by Jo Hasenau about 14 years ago

Uploaded v2 and v3 of the patch to make sure it's in sync with the core list.

Actions #2

Updated by Jo Hasenau about 14 years ago

preCObject, postCObject, prepend and append will be excluded from nested stdWrap functions as well, since they make use of cObjGetSingle anyway

Actions #3

Updated by Steffen Kamper about 14 years ago

committed v4 to trunk rev 9075

Actions #4

Updated by Susanne Moog over 13 years ago

  • Target version deleted (4.5.0)
Actions

Also available in: Atom PDF