Bug #23912

taskcenter - wrongly created path for icon (in certain conditions)

Added by Krystian Szymukowicz about 10 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-11-02
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.4
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

PROBLEM:
The path for icon in taskcenter is created wtih:
$icon = $GLOBALS['BACK_PATH'] . '../' . str_replace(PATH_site, '', $absIconPath);

There are some edge situations when the PATH_site is equal to "/". In that case the backslash from icon path will be removed and such path of icon generated:
http://example.com/typo3sysextsys_actionx-sys_action.png

SOLUTION:
Check if path is "/"

$icon = $GLOBALS['BACK_PATH'] . '../' . (PATH_site == '/' ? $absIconPath : str_replace(PATH_site, '', $absIconPath));

(issue imported from #M16216)


Files

16216 _taskcenter.patch (690 Bytes) 16216 _taskcenter.patch Administrator Admin, 2010-11-02 11:35
16216_v2_44.patch (777 Bytes) 16216_v2_44.patch Administrator Admin, 2010-11-26 13:15
16216_v2_trunk.patch (777 Bytes) 16216_v2_trunk.patch Administrator Admin, 2010-11-26 13:15
16216_v3.patch (740 Bytes) 16216_v3.patch Administrator Admin, 2010-12-09 11:10
16216_v3_44.patch (740 Bytes) 16216_v3_44.patch Administrator Admin, 2010-12-09 11:10
Screenshot.png (27 KB) Screenshot.png Administrator Admin, 2010-12-10 15:20
#1

Updated by Kevin Ulrich Moschallski almost 10 years ago

Hi,

which TYPO3 version does this patch belongs to?

#2

Updated by Krystian Szymukowicz almost 10 years ago

Seems like the path in the patch is wrong.

I will create second patch.

#3

Updated by Krystian Szymukowicz almost 10 years ago

New version of patch with relative pathes uploaded. Sorry for trouble.

#4

Updated by Kevin Ulrich Moschallski almost 10 years ago

+1 by reading and testing.

Can't find this issue in the core list, did you post it there?

#5

Updated by Krystian Szymukowicz almost 10 years ago

Tnx.
Yes it was posted on 2010.11.02

#6

Updated by Krystian Szymukowicz almost 10 years ago

v3 - new version of the patch according to Jeff Segars suggestions.

#7

Updated by Alexander Opitz about 7 years ago

  • Target version deleted (0)
  • TYPO3 Version set to 4.4
  • Is Regression set to No

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?

#8

Updated by Georg Ringer almost 6 years ago

  • Status changed from New to Closed

task center has been redone with 4.5, therefore I am closing this issue.

feel free to reopen if still valid

Also available in: Atom PDF