Bug #24104: Replace exec_SELECTgetRows with exec_SELECTgetSingleRow whenever a single record is expected - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #24104

closed

Replace exec_SELECTgetRows with exec_SELECTgetSingleRow whenever a single record is expected

Added by Jo Hasenau over 13 years ago. Updated about 13 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Christian Kuhn

Category:

Target version:

Start date:

2010-11-17

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.5

PHP Version:

5.2

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

In the core the method exec_SELECTgetRows is used to fetch records from the DB. Often this method is uses, even though there is just one single record expected as a result.

Attached patch replaces exec_SELECT-getRows with exec_SELECTgetSingleRow for each case dealing with single records.

Indicators are:
list(blah) is used in front of exec_SELECTgetRows
$blah⁰ is used only
array_shift is used and the rest of the array stays untouched
LIMIT 1 is used within the method

and the array is not used with any foreach loop.

(issue imported from #M16445)

Files

Download all files

replace_getRows_with_getSingleRow.diff (26.5 KB) replace_getRows_with_getSingleRow.diff		Administrator Admin, 2010-11-17 15:33
16445_02.diff (24.6 KB) 16445_02.diff		Administrator Admin, 2010-11-26 19:09