Project

General

Profile

Actions

Bug #24847

closed

PHP_SCRIPT_EXT in 4.5 doesn't work

Added by Philipp Idler about 13 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2011-01-27
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

reproduce:

page.10 = PHP_SCRIPT_EXT
page.10.file = fileadmin/scripts/phpinfo.php

set version back to 4.4.6 and it works again

(issue imported from #M17351)


Files

17351.diff (6.08 KB) 17351.diff Administrator Admin, 2011-01-29 19:16
Actions #1

Updated by Jason Alexander about 13 years ago

I can confirm. This issue is also happening to me.

Actions #2

Updated by Administrator Admin about 13 years ago

Confirmed: Just updated from v4.4.6 to v4.5.0 and ran right into it.

Actions #3

Updated by Jo Hasenau about 13 years ago

Both, PHP_SCRIPT_INT and PHP_SCRIPT_EXT don't seem to work properly, while PHP_SCRIPT does.

Attached patch should fix this bug.

It splits up the PhpScriptInternal class in two separate classes, since the parameter to distinguish between INT and EXT is not available.

Tested with all 3 kinds of PHP_SCRIPT - please try if this works for you.

Actions #4

Updated by Administrator Admin about 13 years ago

@Jo

Great! This works for me.
I upgraded from v4.4.2 to v4.5.0 => no PHP_SCRIPT_EXT no more.

Maybe you should state that class.tslib_content_phpscriptexternal.php has to be created. At first I was puzzled it was 'missing'...

Status Solved! Thanks.

Actions #5

Updated by Administrator Admin about 13 years ago

Confirmed, but cannot patch since we want to make sure PHP_SCRIPT_EXT will continue to be supported officially before upgrading; otherwise, we will need to move away from using it before we can upgrade.

Actions #6

Updated by Administrator Admin about 13 years ago

I can confirm the Bug and that the diff is working. Would be nice if the next version contained this fix...

Actions #7

Updated by Ernesto Baschny about 13 years ago

We will include that in 4.5.1, thanks for reporting and Joey for the fix. Ready for an RFC on the core list?

Actions #8

Updated by Jo Hasenau about 13 years ago

Will do

Actions #9

Updated by Jigal van Hemert about 13 years ago

Committed to trunk rev: 10384

Actions #10

Updated by Jigal van Hemert about 13 years ago

Committed to 4_5 rev: 10387

Actions

Also available in: Atom PDF