Bug #25302: Broken links representation gets saved to the database - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #25302

closed

Broken links representation gets saved to the database

Added by Oliver Hader over 13 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Stanislas Rolland

Category:

RTE (rtehtmlarea + ckeditor)

Target version:

Start date:

2011-03-10

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.4

PHP Version:

5.3

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Imagine that you have a content element with a link to a internal page that does not exist anymore. On editing this content element, RTEhtmlarea marks this link with yellow background and a red border.
On saving the form without touching the content in the RTE at all, the styles used for representing this broken link are saved to the database and then get wrapped by an addition span tag.

So, on saving again one will end out in something like this:

< p >< em >
  < span style="background-color: yellow; border:2px red solid; color: black;" >
    < a style="background-color: yellow; border:2px red solid; color: black;" rteerror="No page found: 2913" title="Opens internal link in current window" class="internal-link" href="http://dev45.local/?id=99999" >TEST< /a >
  < /span >
< /em >< /p >

(issue imported from #M17917)

Files

Download all files

0017917_screenshot.png (36.2 KB) 0017917_screenshot.png		Administrator Admin, 2011-03-10 12:20
0017917.patch (770 Bytes) 0017917.patch		Administrator Admin, 2011-03-11 17:49

Actions

Copy link

Updated by Oliver Hader over 13 years ago

This is a tricky one. The call to TS_transform_db() in t3lib_parsehtml_proc will add the span tag around the anchor. The call to TS_links_db() would have removed the rteerror and style attributes of that broken anchor tag. However, since TS_links_db() is called after TS_transform_db() the span tag is already there.

So my patch just changes the order of processing the modes, to have ts_links before ts_transform/css_transform. I'm not an expert on the ParseHtml class and thus also don't know about negative side-effects.

Actions

Copy link

Updated by Oliver Hader over 13 years ago

Subject changed from Broken links representation gets save to the database to Broken links representation gets saved to the database
Category set to RTE (rtehtmlarea + ckeditor)
Target version changed from 0 to 1061
TYPO3 Version set to 4.4