Project

General

Profile

Actions

Bug #25371

closed

wrong display of csh icon and text in new record wizzard

Added by Sebastian Müller over 13 years ago. Updated over 13 years ago.

Status:
Closed
Priority:
Should have
Category:
Backend User Interface
Target version:
Start date:
2011-03-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

For each TCA-Table where you can add an element on a side, there is displayed a csh icon with text if (text ist configured). In db_new.php is a wrong variable used so the csh text of the last tca-table is allways used and for each table. So it will also be displayed for tables which orginally got no csh text.

Additionally due to a missing break, csh icons of a tca-table is displayed in the wrong line.

How to reproduce: Install tt_news, go to a site where you can insert tt_news records (not root) and click the "create new record" icon. See csh_bug.png
(issue imported from #M18006)


Files

csh_bug.png (26 KB) csh_bug.png Administrator Admin, 2011-03-22 08:51
Actions #1

Updated by Sebastian Müller over 13 years ago

bugfix will be pushed (as soon as git pushing works by me) to review.typo3.org

Actions #2

Updated by Sebastian Müller over 13 years ago

  • Target version deleted (0)

Finally I got the time to get it working and was able to push it to review.typo3.org.

Unfortunately I'm not sure about how to handle master (4.6) and branch TYPO3_4-5. Do I have to create 2 Issues and 2 Commits?

Thanks to Susanne Moog for moving issue from bugs to forge.

Actions #3

Updated by Steffen Gebert over 13 years ago

Hi Christian,

thanks for the Change Request!
Please wait until the change is submitted for master, then push it again for 4-5 as described in the Tutorial

Thanks!
Steffen

Actions #4

Updated by Sebastian Müller over 13 years ago

Hey,

it's Sebastian, not Christian.

Can I also do it the other way? Since I already pushed the bugfix for 4-5.

Thanks for your answer,
Sebastian

Actions #5

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change I7c4b0fec0e8c5c0a6947dec9c30b4c2ff3960d05 has been pushed to the review server.
It is available at http://review.typo3.org/1304

Actions #6

Updated by Sebastian Müller over 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Francois Suter over 13 years ago

  • Category set to Backend User Interface
  • Assignee set to Francois Suter
  • Target version set to 4.5.3
  • PHP Version set to 5.3
Actions #8

Updated by Oliver Hader over 13 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF