Project

General

Profile

Actions

Bug #25572

closed

wrong line height for the linecounter

Added by Stefan Froemken over 14 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Administrator Admin
Category:
t3editor
Target version:
-
Start date:
2009-11-26
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Let's have a look at the picture t3editor.png and you will see, that the 7th line is one the same height than the 6th line of written code.

(issue imported from #M12774)


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #25525: Pasting TS problemsClosedAdministrator Admin2008-04-25

Actions
Actions #1

Updated by Jochen Weiland over 14 years ago

There is a dependancy on the browser/OS combination.

On Mac with Firefox it is ok
On Mac with Safari and on Windows with all browsers the line spacing of the numbering does not match the line spacing of the code in the t3editor. See file t3editor.jpg for a comparison (10 lines of code shown for each combination, numering ranges from 1-10 to 1-12

Actions #2

Updated by Gregor Hermens about 14 years ago

The height of .t3e_linenum dt (t3editor.css: 13px) has to match the line-height of .editbox (t3editor_inner.css), which is not set. Attached patch 12774.diff sets the the line-height to 13px.

I would prefer a line-height of 14px or more for better readability, see patch 12774v2.diff...

Sorry, bug_13630.diff doesn't belong here. Please delete if possible.

Actions #3

Updated by Administrator Admin almost 14 years ago

i've updated the codemirror library, which now supports linenumbers by itself. It should work much better now.

Please check if your issue is solved in TYPO3-4.4beta2. Thanks.

Actions #4

Updated by Gregor Hermens almost 14 years ago

Looks good in TYPO3-4.4beta3. :-)

Actions #5

Updated by Michael Stucki over 10 years ago

  • Project changed from 75 to TYPO3 Core
  • Target version deleted (0)
Actions #6

Updated by Michael Stucki over 10 years ago

  • Category set to t3editor
Actions #7

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF