Project

General

Profile

Actions
Copy link

Bug #26090

closed

Remove old code related to extension tstemplate_styler (sys_template:editorcfg)

Added by Patrick Rodacker over 13 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-04-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

I stumbled upon different places in the TYPO3 core where code related to the extension tstemplate_styler is still present. IMHO the code should be removed, because the extension tstemplate_styler is not shipped with the core. I don't know what is the best way to move configuration options from the extensions, but I think they should not stay in the core.

These are some issues I have identified on a quick search about this topic:

  • the field editorcfg in the record sys_template still exists.
  • configuration options $TYPO3_CONF_VARS['FE']['defaultTypoScript_editorcfg'] and $TYPO3_CONF_VARS['FE']['defaultTypoScript_editorcfg.'] still present
  • Extension Manager still supporting the settings (e.g. ext_typoscript_editorcfg.txt)

I don't know if the deprecated policy is the best way to handle this.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #99761: Remove superfluous translation sys_template.editorcfgClosedJosef Glatz2023-01-31

Actions
Actions
Copy link
 #1

Updated by Benni Mack over 13 years ago

Hey Patrick,

good point.

I suggest that "tstemplate_styler" should add the field and the options (via hooks) and then we need some sort of upgrade wizard. Although I have to say, that this is completely unused now (I haven't seen an installation in the last 3 ys making use of that feature anymore).

Actions
Copy link
 #2

Updated by Mr. Jenkins almost 13 years ago

  • Status changed from New to Under Review

Patch set 1 of change Ic864276be13b069838f8950e43b864f1c12b3f75 has been pushed to the review server.
It is available at http://review.typo3.org/6972

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 13 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6972

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 13 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6972

Actions
Copy link
 #5

Updated by Dmitry Dulepov over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #6

Updated by Benni Mack over 12 years ago

The change breaks the installation of the static_templates extension.
The item with UID=43 was not modified and thus has one value '' too much, please.

Actions
Copy link
 #7

Updated by Benni Mack over 12 years ago

  • Status changed from Resolved to Needs Feedback
Actions
Copy link
 #8

Updated by Alexander Opitz over 11 years ago

Hi Benjamin,

whats the state of this issue?

Actions
Copy link
 #9

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Needs Feedback to Closed
  • Is Regression set to No

No feedback within the last 90 days => closing this ticket.

Also the issue was fixed by the merge and I see no revert message.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Actions
Copy link
 #10

Updated by Josef Glatz almost 2 years ago

  • Related to Task #99761: Remove superfluous translation sys_template.editorcfg added
Actions
Copy link

Also available in: Atom PDF