Project

General

Profile

Actions

Task #26505

closed

Using the PHP5 constructors

Added by Stefano Kowalke over 13 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Must have
Category:
Miscellaneous
Target version:
Start date:
2011-04-29
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

Using the new PHP5 constructors (__construct) instead of PHP4 variants.


Files

findPHP4ConstructorsT3.sh (938 Bytes) findPHP4ConstructorsT3.sh Stefano Kowalke, 2011-04-30 15:28
findPHP4ConstructorsT3.sh (896 Bytes) findPHP4ConstructorsT3.sh Updated shell script to find PHP4 constructors Stefano Kowalke, 2011-05-24 11:33

Related issues 3 (0 open3 closed)

Precedes TYPO3 Core - Bug #27001: Fatal error: Call to undefined method TBE_FolderTree::t3lib_folderTree() in class.browse_links.phpClosedStefano Kowalke2011-05-24

Actions
Precedes TYPO3 Core - Bug #28208: [4.6] Disallowed compatibility break in tslib_pibaseClosed2011-07-14

Actions
Precedes TYPO3 Core - Bug #28246: Deprecate PHP4 constructorsClosedXavier Perseguers2011-07-15

Actions
Actions #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Iab19b1be570cde143dacbbe244aedaf2dd8ce1a6 has been pushed to the review server.
It is available at http://review.typo3.org/1797

Actions #2

Updated by Stefano Kowalke over 13 years ago

In bugday chat someone mentioned, that this change could beak backward compatibility for some extensions. For version 4.6 this is ok, but we should take care of constructor calls within the core.

I attached a little bash script which search all files (*.php and *.inc) for PHP4 constructor calls. I found nothing.

Usage: findPHP4ConstructorsT3.sh <path>
<path> The path your files are in

Actions #3

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change Iab19b1be570cde143dacbbe244aedaf2dd8ce1a6 has been pushed to the review server.
It is available at http://review.typo3.org/1797

Actions #4

Updated by Xavier Perseguers over 13 years ago

  • Status changed from New to Resolved
Actions #5

Updated by Georg Ringer over 13 years ago

  • Status changed from Resolved to On Hold
  • Priority changed from Should have to Must have

Hey,

sorry but this change broke something: Create a content element "text w images" and try to add an image using the element browser:

Fatal error: Call to undefined method TBE_FolderTree::t3lib_folderTree() in C:\xampp\htdocs\currenttrunk\typo3\class.browse_links.php on line 460

this is because you removed the function from t3lib_foldertree! I don't know if this is allowed, as the function is not declared private it needs to be deprecated first, IMO

Actions #7

Updated by Steffen Gebert about 13 years ago

  • Status changed from On Hold to Resolved

This is already resolved with #27001

Actions #8

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF