TYPO3 Core

Yes, since a very long time.

Can you make a patch and push it to the review server at https://review.typo3.org/?

Further information about posting change requests are documented in the wiki: http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

I am willing to help. I followed the exact instructions in http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine but when I want to commit, the following happens:

stephan-mac-mini:mod sgrossberndt$ git push origin HEAD:refs/for/TYPO3_4.5/26914
Counting objects: 13, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 770 bytes, done.
Total 7 (delta 6), reused 0 (delta 0)
remote: Resolving deltas:   0% (0/6)
To ssh://grossberndts@review.typo3.org:29418/TYPO3v4/Core.git
 ! [remote rejected] HEAD -> refs/for/TYPO3_4.5/26914 (branch TYPO3_4.5/26914 not found)
error: failed to push some refs to 'ssh://grossberndts@review.typo3.org:29418/TYPO3v4/Core.git'

Whats wrong? Can you help me out?

Hi,

You have to push to refs/for/TYPO3_4-5 instead.

HTH

Patch set 1 of change I3a13bc66a171154537109849741afb4f43e24aca has been pushed to the review server.
It is available at http://review.typo3.org/2259

Thanks!

By mistake I pushed to "refs/for/TYPO3_4-5/issue_26914" and not "refs/for/TYPO3_4-5/26914".

Is this ok or do I have to change something?

The change was accepted and is available at https://review.typo3.org/2259

Stephan Grossberndt wrote:

Thanks!

By mistake I pushed to "refs/for/TYPO3_4-5/issue_26914" and not "refs/for/TYPO3_4-5/26914".

Is this ok or do I have to change something?

The change was accepted and is available at https://review.typo3.org/2259

Forget the "26914" part, it's not needed! Just use

$ push origin HEAD:refs/for/TYPO3_4-5

period.

Xavier Perseguers wrote:

Forget the "26914" part, it's not needed! Just use

$ push origin HEAD:refs/for/TYPO3_4-5

period.

Sorry to get on your nerves. This is (obviously) the first time I try to create a patch with git.

According to http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine:

To submit the patch to Gerrit, issue the following command:
shell script:

git push origin HEAD:refs/for/<release-branch>/<topic>

where <release-branch> could be "master", "TYPO3_4-5" and <topic> is the "Topic" to create on Gerrit (the number of the issue in Forge). The topic will be used to group a set of related review requests. In this case:
shell script:

git push origin HEAD:refs/for/master/1234

The first patch set I have created was for "TYPO3_4-5", the second I have prepared now is for "master" instead, since this applies to all branches.

If I push to master (instead of TYPO3_4-5), do I have to use <topic> or is it not needed in general? If not, http://wiki.typo3.org/Contribution_Walkthrough_with_CommandLine should be updated.

Please! You don't get on my nerves. I know that working with Git and Gerrit is not completely trivial at first.

What you do is then correct. I must say I did not add the <topic> part yet as it is automatically generated for me when I push to Gerrit and as long as I don't have to "glue" different patch sets together, it's just fine leaving it.

Patch set 1 of change I8f2d74f4449c8fa66767d7c970bd2b30c865abe3 has been pushed to the review server.
It is available at http://review.typo3.org/2267

Patch set 1 of change I0de40afe0c1253bef8194ce99675a6cd3895e5de has been pushed to the review server.
It is available at http://review.typo3.org/2299

Patch set 2 of change I0de40afe0c1253bef8194ce99675a6cd3895e5de has been pushed to the review server.
It is available at http://review.typo3.org/2299

Patch set 1 of change I6a9f716c35cc635405270051d7aafc3614e2139f has been pushed to the review server.
It is available at http://review.typo3.org/2492

Patch set 1 of change I325161da5dc4750c22d5565dff55769a26885f51 has been pushed to the review server.
It is available at http://review.typo3.org/2493