Bug #27098

Fatal error when downloading extension files

Added by Jeff Segars almost 10 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Extension Manager
Target version:
Start date:
2011-05-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When attempting to download files from the "Edit Files" page in the Extension Manager, a fatal error occurs. This is because the downloadFile URL parameter is not decoded first.

#1270853980: TYPO3 Fatal Error: Error while trying to download the extension file... 

RuntimeException thrown in file
/usr/bin/wecsharedsource/typo3_src-trunk/typo3/sysext/em/classes/index.php in line 1677.

3 SC_mod_tools_em_index::showExtDetails("felogin")

/usr/bin/wecsharedsource/typo3_src-trunk/typo3/sysext/em/classes/index.php:
00432:   // Command given which is executed regardless of main menu setting:
00433:   if ($this->CMD['showExt']) { // Show details for a single extension
00434:    $this->showExtDetails($this->CMD['showExt']);
00435:   } elseif ($this->CMD['requestInstallExtensions']) { // Show details for a single extension
00436:    $this->requestInstallExtensions($this->CMD['requestInstallExtensions']);

2 SC_mod_tools_em_index::main()

/usr/bin/wecsharedsource/typo3_src-trunk/typo3/sysext/em/classes/index.php:
02594: $SOBE->checkExtObj();
02595: 
02596: $SOBE->main();
02597: $SOBE->printContent();
02598: 

1 require("/usr/bin/wecsharedsource/typo3_src-trunk/typo3/sysext/em/classes/index.php")

/usr/bin/wecsharedsource/typo3_src-trunk/typo3/mod.php:
00049:  require($temp_path . 'conf.php');
00050:  $BACK_PATH = '';
00051:  require($temp_path . 'index.php');
00052:  $isDispatched = TRUE;
00053: } else {

Files

27098.diff (794 Bytes) 27098.diff Jeff Segars, 2011-05-27 21:37
#1

Updated by Jeff Segars almost 10 years ago

Looks like we just need to urldecode() the filename.

#2

Updated by Stefan no-lastname-given over 9 years ago

I can confirm that the issue also exists in Typo3 4.5.6 and the attached patch fixed the issue for me as well.

Would be great if this fix could also be backported to the 4.5-branch.

#3

Updated by Markus Klein over 9 years ago

Just as a note: This is about the OLD EM!

#4

Updated by Mr. Hudson over 9 years ago

Patch set 1 of change I6980a0fbe8967bff0df0d8d7bc4c8f1abf53615e has been pushed to the review server.
It is available at http://review.typo3.org/5578

#5

Updated by Mr. Hudson over 9 years ago

Patch set 1 of change Ibd8f71fbc0ff8d9761b35cde713c3c021c6eb31e has been pushed to the review server.
It is available at http://review.typo3.org/5579

#6

Updated by Steffen Gebert over 9 years ago

  • Target version set to 4.5.7
  • TYPO3 Version changed from 4.6 to 4.5

I would say this does not apply to master, as the old EM modules have been dropped there.

#7

Updated by Markus Klein over 9 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100
#8

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF