Bug #27250
closed
Bug #25335: Make TYPO3 free of NOTICE errors
Get rid of error_reporting() at various places in the source
100%
Description
At several places we currently have:
error_reporting(E_ALL ^ E_NOTICE ^ E_DEPRECATED);
I'd suggest we should leave it up to the administrator if he wants TYPO3 to "mess" with his error_reporting or not. Currently things like E_NOTICE can't even be activated explicitly for testing.
We could have an error_reporting-setting in installtool and if this localconf-variable is set, we'll set error_reporting(). But it can also be explicitly not set. Migration from TYPO3 4.5 to 4.6 (as with forceCharset on the move 4.4 to 4.5) should be to automatically set this to E_ALL ^ E_NOTICE ^ E_DEPRECATED in upgrade-wizard.
It also would make working on #25335 (getting rid of E_NOTICE-errors in the core) a lot easier.
Updated by
Updated by Alexander Opitz about 10 years ago
- Status changed from New to Needs Feedback
- Is Regression set to No
Hi,
as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.2.4)?
Updated by Stefan Neufeind about 10 years ago
We have error-reporting-settings meanwhile.
Searching across the current master-tree, besides testcases and some libs (adodb) what I found was:
typo3/thumbs.php
22:error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED));
typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php
296: error_reporting(E_ALL & ~(E_STRICT | E_NOTICE | E_DEPRECATED));
I expect in SystemEnvironmentBuilder it is needed? In thumbs.php maybe not since that uses the official bootstrapping?
Updated by Alexander Opitz about 10 years ago
Shouldn't typo3/thumbs.php not deprecate? ;-)
Anyway, it looks like it can be removed.
Updated by Gerrit Code Review about 10 years ago
- Status changed from Needs Feedback to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32783
Updated by Gerrit Code Review about 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32783
Updated by Gerrit Code Review about 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/32785
Updated by Stefan Neufeind about 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6b307242e9bf70bf0492e79d65a5b58a76ae5f45.
Updated by