Project

General

Profile

Actions

Feature #27442

closed

Difference arrays contain insufficient information

Added by Francois Suter over 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2011-06-14
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The row details view in the Workspaces module is based on two arrays containing only the changed fields, one with the Live value of the fields and one with the diff'ed values. These arrays do not contain any reference to the name of the fields, only to their labels.

This is insufficient in case one wants to work on/improve that difference view. I thus propose to add an extra entry for each difference, containing the field name (I tried using the field name directly as the array key, but it breaks the JS display).

I hope this can go into 4.5 too, as it doesn't break anything and we have to live with 4.5 for 3 years.


Related issues 1 (0 open1 closed)

Blocks TYPO3 Core - Feature #12868: Make row detail view customizableClosed2011-02-08

Actions
Actions #1

Updated by Francois Suter over 13 years ago

Patch will follow at some later time. Got stuck with Git submodules...

Actions #2

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Ie2b4088a568a4f9880afdf44e3b5f95cf95215fc has been pushed to the review server.
It is available at http://review.typo3.org/2747

Actions #3

Updated by Michael Klapper over 13 years ago

  • Status changed from New to Needs Feedback

Where can i see new field information in the module?

Actions #4

Updated by Francois Suter over 13 years ago

You can't see it in the module. This information will be useful with the planned hook (see #12868). Otherwise there's no easy way for functions using this hook to know which field they are handling.

Actions #5

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Ie2b4088a568a4f9880afdf44e3b5f95cf95215fc has been pushed to the review server.
It is available at http://review.typo3.org/2775

Actions #6

Updated by Francois Suter over 13 years ago

  • Status changed from Needs Feedback to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:fd5abc860e7d25b57b2c291dfe1096de8496d977.

Actions #7

Updated by Michael Stucki almost 11 years ago

  • Category changed from Extension API to Workspaces
Actions #8

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #9

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF