Project

General

Profile

Actions

Bug #28185

closed

Redirect in FE to 1-2-3 installer broken

Added by Christian Kuhn over 13 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-07-13
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Fix a regression introduced by #27954:

If in FE during db connect the database is not set, this is a sign for a not configured installation so a redirect to the 1-2-3 installer is done. This broke with change 89732c4a in #27954 because the check for db constant is now done too late.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #27954: Change usage of t3lib_DB->sql_pconnect to t3lib_DB->connectDBClosed2011-07-07

Actions
Actions #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I0a7003d876a747e16552fecf6385b0449de5617a has been pushed to the review server.
It is available at http://review.typo3.org/3316

Actions #2

Updated by Helmut Hummel over 13 years ago

I cannot reproduce the problem.

How I tested:

downloaded dummy package, used TYPO3 sources of current master, accessed the frontend.

I was redirected to the 123 installer.

Actions #3

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change I0a7003d876a747e16552fecf6385b0449de5617a has been pushed to the review server.
It is available at http://review.typo3.org/3316

Actions #4

Updated by Steffen Gebert over 13 years ago

I also can't reproduce. Works fine for me.

Actions #5

Updated by Christian Kuhn over 13 years ago

Weird that you are unable to reproduce, I had this immediatly. Maybe this also depends on wether or not dbal is loaded or something like that.

Anyway, codewise the patch is a no-brainer as already stated by Helmut in gerrit. And it is also merged because of that already.

Actions #6

Updated by Christian Kuhn over 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Xavier Perseguers over 12 years ago

  • Status changed from Resolved to Closed
Actions #8

Updated by Ernesto Baschny over 11 years ago

  • Target version deleted (4.6.0-beta1)
Actions

Also available in: Atom PDF