Bug #28320
closedFE Login forgot password hashlink lacks scheme and host when using absRefPrefix
0%
Description
The forgot password email contains a hashlink that lacks scheme and host (see attachment) if
config.absRefPrefixis set in TypoScript Setup. Therfore it's not clickable.
To generate the hashlink (in class tx_felogin_pi1 at line 346 et seq.) config.absRefPrefix and config.baseURL are analysed; config.baseURL (or plugin.tx_felogin_pi1.feloginBaseURL) are used for scheme and host in the link.
In my opinion there is no need for it - it seems to me t3lib_div::locationHeaderUrl() is a better solution.
Suggestion for improvement:
replace lines 367 to 370
$link = ($isAbsRelPrefix ? '' : $this->conf['linkPrefix']) . $this->pi_getPageLink($GLOBALS['TSFE']->id, '', array( $this->prefixId . '[user]' => $user['uid'], $this->prefixId . '[forgothash]' => $randHash ));
by
$link = $this->pi_getPageLink($GLOBALS['TSFE']->id, '', array( $this->prefixId . '[user]' => $user['uid'], $this->prefixId . '[forgothash]' => $randHash )); $link = t3lib_div::locationHeaderUrl($link);
Files
Updated by Ulfried Herrmann over 13 years ago
Comparing the code felogin 1.3.1 (TYPO3 4.5.3) should have the same behaviour.
Updated by Tolleiv Nietsch over 13 years ago
Would you mind sending a patch to Gerrit? ( Description see: http://wiki.typo3.org/Contribution_Walkthrough_Tutorials)
Updated by Mr. Hudson over 13 years ago
Patch set 1 of change I5b98973b231c19c1b33221308338adb78f34388b has been pushed to the review server.
It is available at http://review.typo3.org/3706
Updated by Mr. Hudson over 13 years ago
Patch set 2 of change I5b98973b231c19c1b33221308338adb78f34388b has been pushed to the review server.
It is available at http://review.typo3.org/3706
Updated by Mr. Hudson over 13 years ago
Patch set 3 of change I5b98973b231c19c1b33221308338adb78f34388b has been pushed to the review server.
It is available at http://review.typo3.org/3706