Actions
Bug #28320
closedFE Login forgot password hashlink lacks scheme and host when using absRefPrefix
Status:
Closed
Priority:
Should have
Assignee:
-
Category:
felogin
Target version:
-
Start date:
2011-07-19
Due date:
% Done:
0%
Estimated time:
TYPO3 Version:
4.4
PHP Version:
5.2
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:
Description
The forgot password email contains a hashlink that lacks scheme and host (see attachment) if
config.absRefPrefixis set in TypoScript Setup. Therfore it's not clickable.
To generate the hashlink (in class tx_felogin_pi1 at line 346 et seq.) config.absRefPrefix and config.baseURL are analysed; config.baseURL (or plugin.tx_felogin_pi1.feloginBaseURL) are used for scheme and host in the link.
In my opinion there is no need for it - it seems to me t3lib_div::locationHeaderUrl() is a better solution.
Suggestion for improvement:
replace lines 367 to 370
$link = ($isAbsRelPrefix ? '' : $this->conf['linkPrefix']) . $this->pi_getPageLink($GLOBALS['TSFE']->id, '', array( $this->prefixId . '[user]' => $user['uid'], $this->prefixId . '[forgothash]' => $randHash ));
by
$link = $this->pi_getPageLink($GLOBALS['TSFE']->id, '', array( $this->prefixId . '[user]' => $user['uid'], $this->prefixId . '[forgothash]' => $randHash )); $link = t3lib_div::locationHeaderUrl($link);
Files
Actions