Project

General

Profile

Actions

Bug #28354

closed

Regression: filelistFolderTree constructor is recursive

Added by Philipp Gampe over 13 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Backend API
Target version:
-
Start date:
2011-07-20
Due date:
% Done:

100%

Estimated time:
0.20 h
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

After fix of compatibility constructor, the real constructor (__construct) is missing. This leads to a recursive call on itself and thus crashes.

Adding a constructor which calls parent::__construct solves the issue.

Actions #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Ic788b8dfb9ae42a4ad7c1b9a122f31de1df98741 has been pushed to the review server.
It is available at http://review.typo3.org/3445

Actions #2

Updated by Georg Ringer over 13 years ago

can you add a howto for testing? what crashes where?

Actions #3

Updated by Philipp Gampe over 13 years ago

The filelist module. The tree crashes (you have to reload the frame to see it).

Crashing means that it hits the max nesting level (1000). Debugging shows that it calls itself and thus can not work.

Fatal error: Maximum function nesting level of '1000' reached, aborting! in /home/phil/t3-playground/t3-git/t3lib/class.t3lib_div.php on line 3787
Call Stack
#    Time    Memory    Function    Location
1    0.0003    702720    {main}( )    ../alt_file_navframe.php:0
2    0.1104    17658576    SC_alt_file_navframe->init( )    ../alt_file_navframe.php:292
3    0.1104    17658760    t3lib_div::makeInstance( )    ../alt_file_navframe.php:84
4    0.1104    17665448    filelistFolderTree->filelistFolderTree( )    ../class.t3lib_div.php:4713
5    0.1107    17665528    filelistFolderTree->filelistFolderTree( )    ../class.filelistfoldertree.php:77
6    0.1109    17665528    filelistFolderTree->filelistFolderTree( )    ../class.filelistfoldertree.php:77
7    0.1111    17665528    filelistFolderTree->filelistFolderTree( )
... all the way down to 999
Actions #4

Updated by Philipp Gampe over 13 years ago

Some server info:

Name        : php
Arch        : x86_64
Version     : 5.3.6
Release     : 2.fc15
Size        : 3.6 M

Name        : php-pecl-xdebug
Arch        : x86_64
Version     : 2.1.1
Release     : 1.fc15
Size        : 617 k

Name        : httpd
Arch        : x86_64
Version     : 2.2.17
Release     : 10.fc15.1
Size        : 2.9 M

php -i|fpaste (next 24 hours)

Actions #5

Updated by Xavier Perseguers over 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 80 to 100

Change has been successfully cherry-picked as 039c4473805b62700a28202c23c04404e26b116d.

Actions #6

Updated by Xavier Perseguers over 12 years ago

  • Status changed from Resolved to Closed
Actions #7

Updated by Ernesto Baschny over 11 years ago

  • Target version deleted (4.6.0-beta1)
Actions

Also available in: Atom PDF