Bug #28455: "New record" button in WEB/Template module does not work anymore - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #28455

closed

"New record" button in WEB/Template module does not work anymore

Added by Katja Lampela over 13 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend User Interface

Target version:

Start date:

2011-07-25

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

Can't create a new (extension) template with WEB/Template module anymore, TYPO3 4.5.x and 4.6.x.

Before, when you had WEB/Template and a sysfolder chosen, clicking the "New record" icon created a new ext template. This does not work anymore.
(Creating a new tempate in WEB/List still works.)

Files

new-template.png (38.6 KB) new-template.png

Steffen Gebert, 2011-07-25 18:53

Actions

Copy link

Updated by Steffen Gebert over 13 years ago

File new-template.png new-template.png added
Category set to Backend User Interface
Status changed from New to Needs Feedback

Hi Katja,

I don't exactly get the point. Doesn't the following screen appear for you?

Actions

Copy link

Updated by Xavier Perseguers over 13 years ago

And once you have a template, you may add a new with the "+" top bar icon that appears when using Info/Modify in the function menu.

Actions

Copy link

Updated by Katja Lampela over 13 years ago

Ok, I checked, it is browser version and/or device dependent. Creating new template directly with the Web/Template doesn't work with Firefox 5 + Windows 7, but it does work with Firefox 3.6.18 + Windows XP.

Actions

Copy link

Updated by Chris topher over 13 years ago

Subject changed from Can't create a new (extension) template with WEB/Template module anymore to "New record" button in WEB/Template module does not work anymore

I can reproduce the problem with FF5 on Windows XP.

@ Steffen: Above the part we see in your screenshot there is the docheader and inside there is the button "New record". I tried it in a sysfolder and no "new record" screen comes up. Instead I come to the same screen again.

When I click the button in FF5 the following URL is requested:

[POST] http://localhost/typo3/sysext/tstemplate/ts/index.php?id=95

Actions

Copy link

Updated by Steffen Gebert over 13 years ago

Status changed from Needs Feedback to Accepted
Complexity set to easy

Okay, now I understand.

I assume it only happens in Firefox 5.

The icon above is an <input type="image" name="createExtension" value="New">, which sends a form on click. With e.g. Chrome, the following POST data is sent:

createExtension       New
createExtension.x     8
createExtension.y     9
SET[function]         tx_tstemplateinfo
createStandard

With Firefox, this information is sent:

createExtension.x     8
createExtension.y     9
SET[function]         tx_tstemplateinfo
createStandard

So it only contains the coordinates of the image, which is clicked, but not the name="value" combination createExtension="New". However, this POST parameter is checked in @SC_mod_web_ts_index::createTemplate().

Possible ways to fix:

Change the name of the image and add a hidden input field
Check in the PHP code for createExtension || createExtension.x
Search, whether this is a bug in FF5.

Actions

Copy link

Updated by Steffen Gebert over 13 years ago

Oh, well.. was easier to find than I expected: It's not a bug in Firefox

Actions

Copy link

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change Id6424c44978be807c51bcdd842d11761d9aa947e has been pushed to the review server.
It is available at http://review.typo3.org/4405

Actions

Copy link

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change Id6424c44978be807c51bcdd842d11761d9aa947e has been pushed to the review server.
It is available at http://review.typo3.org/4405

Actions

Copy link

Updated by Jigal van Hemert over 13 years ago

Status changed from Accepted to Resolved
% Done changed from 0 to 100

Applied in changeset de9f8dd27b1f40d03c5d3a2b7c007360f75d8d93.

Actions

Copy link

#10

Updated by Xavier Perseguers over 13 years ago

Status changed from Resolved to Under Review
% Done changed from 100 to 90

This patch is marked as to be part of 4.5 as well. Where is the patch? It only was committed to master SFIK. When there are enough +1 in Gerrit, the final committer has to push the corresponding patches for the other mentioned branches and merge them as well.

Please do so. Thanks.

Actions

Copy link

#11