Project

General

Profile

Actions

Task #28669

closed

Optimizations for IPv6-functions in t3lib_div

Added by Stefan Neufeind over 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2011-08-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

  • speedup: use IPv6-support from PHP if present (usually enabled; fallback present)
  • since there is IPv6Hex2Bin(), also add IPv6Bin2Hex()
  • since there is normalizeIPv6(), also add compressIPv6()
  • normalization also involves converting to lowercase
    • lowercase recommended according to RFC
    • common case needed for string-comparisons to work as expected
  • checking for strlen(...) of 39 (length of already normalized IPv6) should be done in normalizeIPv6() and not all other functions trying to find out if they need to call normalizeIPv6() or not
  • extend unit-tests
Actions #1

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I7c9eda4de0f2c06f06a530f1180233d592f9dfdc has been pushed to the review server.
It is available at http://review.typo3.org/4019

Actions #2

Updated by Thorsten Kahler over 13 years ago

  • Status changed from New to Under Review
Actions #3

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change I7c9eda4de0f2c06f06a530f1180233d592f9dfdc has been pushed to the review server.
It is available at http://review.typo3.org/4019

Actions #4

Updated by Stefan Neufeind over 13 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF