Project

General

Profile

Actions

Bug #28849

closed

Wrong check for "multiple" in TCEforms

Added by Björn Pedersen over 12 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-08-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The change http://review.typo3.org/972
[BUGFIX] group field in TCEforms does not honor size=1 attribute

changed the way the check for multiple entrys is done. The check is wrong and breaks all dam media fields.

line 5580 in class.t3lib_tceforms.php should be changed to

isMultiple = (fObj.getAttribute("multiple") == null || fObj.getAttribute("multiple") == "multiple" ) && fObj.getAttribute("size") != "1";


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #25221: "group" field in TCEforms does not honor size=1 attributeClosedDmitry Dulepov2011-03-02

Actions
Actions #1

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I429486d93574638db836d7874e473641fb6ec4a6 has been pushed to the review server.
It is available at http://review.typo3.org/4227

Actions #2

Updated by Chris topher over 12 years ago

  • Subject changed from Wrongh check for multiple in TCEforms to Wrong check for "multiple" in TCEforms
Actions #3

Updated by Chris topher over 12 years ago

  • Status changed from New to Under Review
Actions #4

Updated by Björn Pedersen over 12 years ago

How to check/reproduce:

install dam and any dam-enabled fields will only allow one upload.

Actions #5

Updated by Mr. Hudson over 12 years ago

Patch set 2 of change I429486d93574638db836d7874e473641fb6ec4a6 has been pushed to the review server.
It is available at http://review.typo3.org/4227

Actions #6

Updated by Helmut Hummel over 12 years ago

Sorry for insisting, but since I'm not that familiar with DAM; What are "DAM enabled fields"?

Actions #7

Updated by Björn Pedersen over 12 years ago

Dam enabled fields are media fields where dam records are used instead of images. The TCA is changed to type user and the input rendered by a user function in the extension.

Actions #8

Updated by Mr. Hudson over 12 years ago

Patch set 3 of change I429486d93574638db836d7874e473641fb6ec4a6 has been pushed to the review server.
It is available at http://review.typo3.org/4227

Actions #9

Updated by Björn Pedersen over 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF