Project

General

Profile

Actions

Bug #30764

closed

exception side effect in "template setup"

Added by Guido Fögler over 12 years ago. Updated over 10 years ago.

Status:
Rejected
Priority:
Won't have this time
Assignee:
Category:
t3editor
Target version:
-
Start date:
2011-10-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.3
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

try-catch avoids a exception side effect in "template setup"
at "if (!this.mirror.editor)" in typo3/sysext/t3editor/jslib/t3editor.js

problem:
At least in IE9, with "client browser caching" set to another option than "read always" (e.g. automatic or never) the very first touch on "template setup" is rendered as expected.

Any further touch on "template setup" within the same session leads to a incorrect display, due to a thrown exception at "if (!this.mirror.editor)" in case "editor" is undefined.

workaround/solution:
try { if (!this.mirror.editor) return; } catch(e) { return; }


Files

Actions #1

Updated by Steffen Gebert over 12 years ago

Thanks for your report and patch. Could you please push that to the review system Gerrit? Thanks!

Actions #2

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I238c2e7297f162c91dacbece044589cc941b3de1 has been pushed to the review server.
It is available at http://review.typo3.org/6004

Actions #3

Updated by Steffen Gebert over 12 years ago

For me the t3editor is somehow completely broken in IE9 (see screen shot).

Actions #4

Updated by Markus Klein over 12 years ago

Can confirm that with my IE9 too, even after applying the patch.

Guido, can you please give precise instructions how to test this? Are you using any compatibility mode in IE?
Please also provide screen shots how it looks like on your machine before and after you apply the patch.

Thanks.

Actions #5

Updated by Gerrit Code Review over 12 years ago

  • Status changed from New to Under Review

Patch set 2 for branch TYPO3_4-3 has been pushed to the review server.
It is available at http://review.typo3.org/6004

Actions #6

Updated by Stefan Neufeind about 12 years ago

Does this apply to releases newer than 4.3 (up to master?) as well?

Actions #7

Updated by Stefan Neufeind about 12 years ago

please close as "won't fix". As written in gerrit this only affects 4.3 and that branch doesn't receive fixes anymore.

Actions #8

Updated by Tobias Liebig about 12 years ago

  • Status changed from Under Review to Rejected
  • Assignee set to Tobias Liebig
  • Priority changed from Should have to Won't have this time
  • % Done changed from 0 to 100
Actions #9

Updated by Michael Stucki over 10 years ago

  • Project changed from 75 to TYPO3 Core
Actions #10

Updated by Michael Stucki over 10 years ago

  • Category set to t3editor
Actions

Also available in: Atom PDF