Bug #32515

Form values with newlines are displayed with <br/>'s in email

Added by Alexander Dick over 9 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2011-12-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

When entering a text with newlines in a textarea, the newlines are displayed as <br/>'s in the resulting email.

File: typo3/sysext/form/Classes/View/Mail/Html/Element/Abstract.php
Function: getInputValue()

The input value is first parsed through nl2br() and then through htmlspecialchars(), which results in escaped <br/> tags instead of real <br/> Tags (for the html mail).

#1

Updated by Steffen Gebert over 9 years ago

Thanks for your report, Alexander! Can you reverse that order and submit the code to the review procedure? See http://wiki.typo3.org/Git. Would be awesome!

#2

Updated by Oliver Hader over 9 years ago

  • Status changed from New to Accepted
#3

Updated by Oliver Hader over 9 years ago

  • PHP Version set to 5.3
#4

Updated by Gerrit Code Review over 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9020

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9020

#6

Updated by Andreas Mayer over 8 years ago

Can confirm this behaviour for Typo3/4.7.4. Do you still need a review?

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9020

#8

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9020

#9

Updated by Gerrit Code Review over 8 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9020

#10

Updated by Helmut Hummel over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#11

Updated by Helmut Hummel over 8 years ago

  • Status changed from Resolved to Accepted
  • % Done changed from 100 to 50

Reverted for now. Merged after merge freeze and test needs to be improved.

#12

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16798

#13

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/16801

#14

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16804

#15

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16825

#16

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16825

#17

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/16825

#18

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at http://review.typo3.org/16871

#19

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/16798

#20

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/16801

#21

Updated by Helmut Hummel over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 50 to 100
#22

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF