Bug #32781

transparent backColor causes transparent flicks and black background

Added by Georg Großberger over 10 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-12-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The backColor = transparent feature is a little unstable, for two reasons:
  1. It may creates wrong transparent areas. That is because of the imagealphablending setting, which should not be there.
  2. It creates black backgrounds, when using an image object inside the GIFBUILDER, because the core sets the t3lib_stdgraphic::imagecopyresized_fix property to true by default.
    Attached is a patch which resolves those issues.

Before pushing it to Gerrit, I'd like to know if the approach of fixing the second issue is correct, or should be done differently.

With this approach, the imagecopyresized_fix is overruled by the saveAlphaLayer property inside the t3lib_stdgraphic::imagecopyresized method. Since this approach is kind of obsolete, I see no problem with it. Backwards compatibility is is given, simply because upraded installations will have the saveAlphaLayer property set to false anyway.

Target Version: 4.6 and 4.7


Files

transparent-backColor-fixes.diff (2.54 KB) transparent-backColor-fixes.diff Georg Großberger, 2011-12-22 13:18
transparent-backColor-fixes.diff (2.37 KB) transparent-backColor-fixes.diff Georg Großberger, 2011-12-22 13:22
demo.tar.gz (19 KB) demo.tar.gz Georg Großberger, 2011-12-25 18:09
#1

Updated by Georg Großberger over 10 years ago

Wrong diff, here is the correct one:

The previous one shows another possible fix of the black background issue, but is not tested so well yet.

#2

Updated by Philipp Gampe over 10 years ago

Would you mind pushing your patch to gerrit?

http://forge.typo3.org/projects/team-forge/wiki/Working_with_Git_and_Gerrit

Would you mind giving us a test setup (typoscript, maybe image) to reproduce the issue (and test the fix). Or describe how to reproduce with the introduction package.

#3

Updated by Georg Großberger over 10 years ago

In the attachment, there is a txt file with a TS setup, and a simple PNG file used as background. I did a page.5 < lib.test.png to put it on display.

Gerrit push is on the way

#4

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/7622

#5

Updated by Xavier Perseguers over 10 years ago

  • Target version deleted (4.6.4)
#6

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9070

#7

Updated by Anonymous over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9070

#9

Updated by Gerrit Code Review about 10 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9070

#10

Updated by Georg Großberger about 10 years ago

  • Status changed from Under Review to Resolved
#11

Updated by Gerrit Code Review almost 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13895

#12

Updated by Georg Großberger almost 10 years ago

  • Status changed from Under Review to Resolved
#13

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF