Project

General

Profile

Actions

Bug #35274

closed

Fix Syntax in typo3/sysext/install/updates/class.tx_coreupdates_t3skin.php

Added by Kay Strobach about 12 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Category:
Install Tool
Target version:
-
Start date:
2012-03-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description


    public function performUpdate(array &$dbQueries, &$customMessages) {
        $result = FALSE;
        if ($this->versionNumber >= 4004000 && !t3lib_extMgm::isLoaded('t3skin')) {
            // check wether the table can be truncated or if sysext with tca has to be installed
            if ($this->checkForUpdate($customMessages[])) {

                                                     ^^
                                                     ||

                              -->      Fix Syntax Problem: Cannot use [] for reading (Message of PHPStorm)

related to 4.5, 4.6, 4.7

Actions #1

Updated by Ernesto Baschny over 11 years ago

  • Status changed from New to Needs Feedback
  • Target version deleted (4.5.14)

Very strange indeed. Doesn't it spit out an error or something? Would be cool to have a patch fixing it, but needs some understanding of what's happening.

Actions #2

Updated by Alexander Opitz over 10 years ago

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions #3

Updated by Kay Strobach over 10 years ago

in the carthasis build with the new installtool this should be fixed, until then this was still valid ... please just take a look into the code :D
Someweeks before i've still seen such a message ...
Atleast for 4.5 this IS NOT FIXED!

Actions #4

Updated by Alexander Opitz over 10 years ago

Hi Kay,

so wie need a fix from 6.1 to 4.5, do you like to make this patch?

Actions #5

Updated by Kay Strobach over 10 years ago

I do not have a running push environment for gerrit currently.
I can provide the *.diff files, but if you want you can push it directly - should be easy :D
I'm currently extremly busy because of my business - sry.

Actions #6

Updated by Alexander Opitz over 10 years ago

  • Assignee set to Alexander Opitz
Actions #7

Updated by Wouter Wolters over 10 years ago

Only needs 4.7 and 4.5

Actions #8

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/22700

Actions #9

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/22700

Actions #10

Updated by Alexander Opitz over 10 years ago

  • Assignee changed from Alexander Opitz to Wouter Wolters

Wouter is faster. ;-)

Actions #11

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/22796

Actions #12

Updated by Wouter Wolters over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF