Bug #35274: Fix Syntax in typo3/sysext/install/updates/class.tx_coreupdates_t3skin.php - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #35274

closed

Fix Syntax in typo3/sysext/install/updates/class.tx_coreupdates_t3skin.php

Added by Kay Strobach over 12 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Wouter Wolters

Category:

Install Tool

Target version:

Start date:

2012-03-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description


    public function performUpdate(array &$dbQueries, &$customMessages) {
        $result = FALSE;
        if ($this->versionNumber >= 4004000 && !t3lib_extMgm::isLoaded('t3skin')) {
            // check wether the table can be truncated or if sysext with tca has to be installed
            if ($this->checkForUpdate($customMessages[])) {

                                                     ^^
                                                     ||

                              -->      Fix Syntax Problem: Cannot use [] for reading (Message of PHPStorm)

related to 4.5, 4.6, 4.7

Actions

Copy link

Updated by Ernesto Baschny over 12 years ago

Status changed from New to Needs Feedback
Target version deleted (~~4.5.14~~)

Very strange indeed. Doesn't it spit out an error or something? Would be cool to have a patch fixing it, but needs some understanding of what's happening.

Actions

Copy link

Updated by Alexander Opitz over 11 years ago

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (4.5 or 6.1)?

Actions

Copy link

Updated by Kay Strobach over 11 years ago

in the carthasis build with the new installtool this should be fixed, until then this was still valid ... please just take a look into the code :D
Someweeks before i've still seen such a message ...
Atleast for 4.5 this IS NOT FIXED!

Actions

Copy link

Updated by Alexander Opitz over 11 years ago

Hi Kay,

so wie need a fix from 6.1 to 4.5, do you like to make this patch?

Actions

Copy link

Updated by Kay Strobach over 11 years ago

I do not have a running push environment for gerrit currently.
I can provide the *.diff files, but if you want you can push it directly - should be easy :D
I'm currently extremly busy because of my business - sry.

Actions

Copy link