Bug #36300
closedSys Action > Create backend user does not load existing user correctly
100%
Description
The selected usergroups are not loaded although code exists to support this:
$selected = (is_array($vars['usergroup']) && t3lib_div::inList(implode(',', $vars['usergroup']), $checkGroup['uid'])) ? ' selected="selected" ' : '';
The $vars array is the raw user record from the DB, where the usergroup list is already comma separated. Removing the code to convert from an array conversion fixes it:
$selected = t3lib_div::inList($vars['usergroup'], $checkGroup['uid']) ? ' selected="selected" ' : '';
I am very curious how this code came in to place :-)
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10706
Updated by Philipp Gampe over 12 years ago
I am very curious how this code came in to place :-)
Use $ git blame -L 750,750 typo3/sysext/sys_action/task/class.tx_sysaction_task.php
:)
2d81d318 (Oliver Hader 2010-06-13 14:56:44 +0000 750) $selected = (is_array($vars['usergroup']) && t3lib_div::inList(implode(',', $vars['usergroup']), $checkGroup['uid'])) ? ' selected="selected" ' : '';
However it seems that this code was checked-in in this way, because the commit from Oliver just cleaned up the svn eol property:
http://git.typo3.org/TYPO3v4/Core.git?a=history;f=typo3/sysext/sys_action/task/class.tx_sysaction_task.php
Updated by Gerrit Code Review over 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10706
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12259
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12261
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/12262
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/12263
Updated by Bart Dubelaar over 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 3f3c20063627cb334fea49c46f84f2f5a0ee5676.
Updated by Gerrit Code Review over 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13157
Updated by Gerrit Code Review over 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13270
Updated by Wouter Wolters about 12 years ago
Please close this issue. All affected branches are up to date.
Updated by Stefan Galinski about 12 years ago
- Status changed from Under Review to Closed