Task #36883
closedChange whitespaces in indentions into tabs (Sysext: Version)
0%
Description
Code have to indent by tabs. There are several places in the core where spaces was used. Change them into tabs.
How to check?¶
I assume PHP_CodeSniffer with the TYPO3v4 standard is installed at you machine, type in the console:
phpcs -v --standard=TYPO3v4 --sniffs=TYPO3.WhiteSpace.DisallowSpaceIndent --ignore=.git,typo3/sysext/openid/lib,typo3/contrib,typo3/sysext/adodb,typo3/sysext/em/mod1/class.nusoap.php,typo3/sysext/fluid,typo3/sysext/extbase,typo3/sysext/indexed_search/class.doublemetaphone.php --extensions=php,inc /Path/To/trunk/typo3/sysext/version
before apply the patch. Than apply the patch and execute phpcs again. All the violations should be gone.
I did the changes manually to see if our sniff works correctly and we do not have some false positives. As far as I can see, it works very well. After merging the patch into core I will activate this sniff on ci.typo3.org for the gerrit and the nightly job.
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11025
Updated by Andy Grunwald about 12 years ago
This change is already merged.
Gerrit does not change the status of this ticket.
Can someone close this?
Updated by Susanne Moog about 12 years ago
- Status changed from Under Review to Closed
Updated by Michael Stucki over 10 years ago
- Category changed from Code Cleanup to Workspaces
Updated by Michael Stucki over 10 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces