Bug #37221: Follow up #35260: Missing selection field in t3lib_TCEmain::getPreviousLocalizedRecordUid() - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #37221

closed

Follow up #35260: Missing selection field in t3lib_TCEmain::getPreviousLocalizedRecordUid()

Added by Felix Nagel over 12 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Francois Suter

Category:

DataHandler aka TCEmain

Target version:

4.5.16

Start date:

2012-05-16

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

5.3

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

Please revert the patch of #35260 as its obviously wrong. Patch of #35260 was included in all branches of TYPO3 afaics, so my patch should be applied to all branches of TYPO3.

Take a look at the function getPreviousLocalizedRecordUid as in TYPO3 4.5.15. First, the whole idea of reusing $sortRow as select statement is just bad practice. Second, using a combination like "sorting,colSort" as an index for $row wont work. Third, the current implementation creates SQL like ' AND sorting,colPos<0 AND ' which wont work.

The idea of adding colSort to select was correct (the function was broken before, too!) but the proposed fix introduces new problems and fixes none.

I have no idea how this could be reviewed by three people as its pretty obvious :-/

Files

0001-BUGFIX-Missing-column-in-t3lib_TCEmain-getPreviousLo.patch (2.54 KB) 0001-BUGFIX-Missing-column-in-t3lib_TCEmain-getPreviousLo.patch

Felix Nagel, 2012-05-16 16:01

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Felix Nagel over 12 years ago

File 0001-BUGFIX-Missing-column-in-t3lib_TCEmain-getPreviousLo.patch 0001-BUGFIX-Missing-column-in-t3lib_TCEmain-getPreviousLo.patch added

Sadly I was not able to push my changes to Gerrit.
When trying to use "scp -p -P 29418 fnagel@review.typo3.org:hooks/commit-msg .git/hooks/" error message is "Permission denied (Publickey)". Any idea how to solve this aka how to copy the hooks?

Patch is attached as a file.

Actions

Copy link

Updated by Georg Ringer over 12 years ago

did you check http://wiki.typo3.org/TroubleShooting_(Git) ?

Actions

Copy link

Updated by Felix Nagel over 12 years ago

Yes, but I triple checked my username, SSH key and everything :-(

Actions

Copy link

Updated by Gerrit Code Review over 12 years ago

Status changed from New to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11250

Actions

Copy link

Updated by Francois Suter over 12 years ago

Thanks for spotting this mistake and sorry for the trouble it caused. I must say I'm really puzzled that it worked at all, given that it seems really wrong, but I can assure you that it solved problems for me or I wouldn't have committed it. Your patch makes it really cleaner. I updated a second version with a modified commit message.

Actions

Copy link

Updated by Felix Nagel over 12 years ago

Im just glad this is fixed now and I finally managed to push my first commit to Gerrit :-)
Thanks for correcting my commit!

Would you mind explain to me why my first push was rejected (build marked as failed) by Gerrit?
And should I verify my own patch? I guess not ;-)

By the way: I managed to push to Gerrit by downloading the hooks manually (like advised in http://forge.typo3.org/projects/team-forge/wiki/Working_with_Git_and_Gerrit) and using 'git commit --amend'.

Actions

Copy link

Updated by Francois Suter over 12 years ago

Assignee set to Francois Suter
PHP Version set to 5.3

Would you mind explain to me why my first push was rejected (build marked as failed) by Gerrit?
And should I verify my own patch? I guess not ;-)

I didn't understand either at first. The problem was that some lines were longer than 74 characters. To find out, you have to follow the link posted by Mr Jenkins and there click on the "Console output" link on the left-hand side. This lists all the details about Mr. Jenkins' complaints.

Actions

Copy link