Bug #37818
closedremoveDefaultCss does not work on render_textpic
100%
Description
Since Typo3 4.7 the textpic adds PageStyle.
I think, if config.removeDefaultCss is set, the PageStyle should not be inserted
If you like, I can send you the patch to gerrit...
Updated by Jigal van Hemert over 12 years ago
- Status changed from New to Needs Feedback
removeDefaultCss prevents the styling in _CSS_DEFAULT_STYLE from being included. texpic adds styling to _CSS_PAGE_STYLE, which is obviously not the same.
We could turn this into a feature for the next major release to have a setting config.removePageStyle.
What do you think?
Updated by Anonymous over 12 years ago
I did not recognized the _CSS_PAGE_STYLE, just see the "_CSS"-stuff...
So your point is absolutly correct and the feature "removePageStyle" would be the only correct solution.
Will this feature go into 4.5, 4.6 and 4.7?
Updated by Dan Kleine (Untenzu) almost 12 years ago
Dirty hack in TypoScript until this is solved: »plugin.tx_cssstyledcontent._CSS_PAGE_STYLE = foo« (causes the check in css_styled_content to be true and render empty inline style tags instead of unwanted default CSS)
@Jigal van Hemert - Since you answered in the first place, whats your opinion/advice to Jürgens question?
Updated by Jigal van Hemert almost 12 years ago
@Dan: Features only go to new (major / minor) releases. At this moment that would mean that it can go into 6.1 .
Can you make a patch and push it to Gerrit?
Updated by Dan Kleine (Untenzu) almost 12 years ago
Thanks Jigal,
I understand that this may only go into 6.1 as this is a feature. For now at least, since this missing feature causes a bug in the ofter versions. I took up your suggestion and pushed a suitable change request to gerrit just now (https://review.typo3.org/#/c/17708/).
I have used »removePageCss« as equivalent to »removeDefaultCss« and _CSS_DEFAULT_STYLE (altough I would like to use »removeDefaultCSS« and »removePageCSS«, since we also use »removeDefaultJS« instead of »removeDefaultJs«).
Suggestion for TSref:
removePageCss boolean Remove specific CSS generated by _CSS_PAGE_STYLE configuration of extensions. Unlike _CSS_DEFAULT_STYLE which outputs a set of default styles if an extensions is installed, _CSS_PAGE_STYLE will render certain styles only if a requirement is met for the given situation (e.g. a textpic element with an image positioned alongside the text will cause some styles to be output, but only if this element does exist on the current page).
Updated by Gerrit Code Review almost 12 years ago
- Status changed from Needs Feedback to Under Review
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17708
Updated by Dan Kleine (Untenzu) over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 3527e46305fb59f6a58686842645c3cf763ec688.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch master_new has been pushed to the review server.
It is available at https://review.typo3.org/18677
Updated by Christian Kuhn over 11 years ago
- Status changed from Under Review to Resolved