Project

General

Profile

Actions

Task #4048

closed

implement interfaces for the hooks provided by the scheduler

Added by Ingo Renner over 15 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
scheduler
Target version:
-
Start date:
2009-07-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

currently the hooks the scheduler provides are very lazy in terms of implementation. To enforce restrictions, interfaces should be defined

Actions #1

Updated by Ingo Renner over 15 years ago

Additionally this should be used to reduce the number of hooks needed to be registered when adding new fields from 3 to 1. IMO it there's little sense in having additional fields without having them stored. Validation might be optional, but shouldn't.

Actions #2

Updated by Francois Suter over 15 years ago

I thought about that, but it's still not clear to me how such interface should be declared, which is why I didn't use any eventually. Could you produce the code changes needed for that? I would then use such code to propose an addition to the CGL.

Actions #3

Updated by Ingo Renner over 15 years ago

Francois Suter wrote:

I thought about that, but it's still not clear to me how such interface should be declared, which is why I didn't use any eventually. Could you produce the code changes needed for that? I would then use such code to propose an addition to the CGL.

For the CGL: It's mainly important to group methods in an interface that depend on each other or don't make sense on their own. (like with the methods for the additional fields)

Actions #4

Updated by Ingo Renner over 15 years ago

  • Status changed from New to Accepted
  • Assignee set to Ingo Renner
Actions #5

Updated by Ingo Renner over 15 years ago

  • Status changed from Accepted to Resolved
  • % Done changed from 0 to 100

Applied in changeset r1054.

Actions #6

Updated by Francois Suter over 15 years ago

Reviewed. Great improvement, makes it much cleaner indeed. Thanks for the work.

Actions #7

Updated by Francois Suter over 15 years ago

Follow-up: only 1 out of 4 hook names had been changed to the new interface (in BE module). They are all changed now...

Actions #8

Updated by Francois Suter over 15 years ago

Francois Suter wrote:

Follow-up: only 1 out of 4 hook names had been changed to the new interface (in BE module). They are all changed now...

in r1072

Actions #9

Updated by Ingo Renner over 15 years ago

Francois Suter wrote:

Follow-up: only 1 out of 4 hook names had been changed to the new interface (in BE module). They are all changed now...

thanks for finding these

Actions #10

Updated by Francois Suter over 12 years ago

  • Status changed from Resolved to Closed
Actions #11

Updated by Michael Stucki almost 11 years ago

  • Category set to scheduler
Actions #12

Updated by Michael Stucki almost 11 years ago

  • Project changed from 739 to TYPO3 Core
  • Category changed from scheduler to scheduler
Actions

Also available in: Atom PDF