Task #4048
closed
implement interfaces for the hooks provided by the scheduler
Added by Ingo Renner over 15 years ago.
Updated almost 11 years ago.
Description
currently the hooks the scheduler provides are very lazy in terms of implementation. To enforce restrictions, interfaces should be defined
Additionally this should be used to reduce the number of hooks needed to be registered when adding new fields from 3 to 1. IMO it there's little sense in having additional fields without having them stored. Validation might be optional, but shouldn't.
I thought about that, but it's still not clear to me how such interface should be declared, which is why I didn't use any eventually. Could you produce the code changes needed for that? I would then use such code to propose an addition to the CGL.
Francois Suter wrote:
I thought about that, but it's still not clear to me how such interface should be declared, which is why I didn't use any eventually. Could you produce the code changes needed for that? I would then use such code to propose an addition to the CGL.
For the CGL: It's mainly important to group methods in an interface that depend on each other or don't make sense on their own. (like with the methods for the additional fields)
- Status changed from New to Accepted
- Assignee set to Ingo Renner
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
Applied in changeset r1054.
Reviewed. Great improvement, makes it much cleaner indeed. Thanks for the work.
Follow-up: only 1 out of 4 hook names had been changed to the new interface (in BE module). They are all changed now...
Francois Suter wrote:
Follow-up: only 1 out of 4 hook names had been changed to the new interface (in BE module). They are all changed now...
in r1072
Francois Suter wrote:
Follow-up: only 1 out of 4 hook names had been changed to the new interface (in BE module). They are all changed now...
thanks for finding these
- Status changed from Resolved to Closed
- Category set to scheduler
- Project changed from 739 to TYPO3 Core
- Category changed from scheduler to scheduler
Also available in: Atom
PDF