TYPO3 Core

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14688

Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/14688

Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/14688

Hi Benni. This ticket is 7 years old. The installation is upgraded to another version, so I cannot check this anymore. But you can simulate the issue easily by creating a cHash from just an id parameter. I think current TYPO3 have safeguards from it, so it will not let you, so you need to comment some checks in CacheHashCalculator. I believe such bad links cannot be created by TYPO3 anymore. However links with cHash still come from search engines or user's bookmarks, so the case is still valid. It still makes 404s due to unneeded cHash.

Hey Dmitry,

ah, I see your point. I think the issue was mitigated when we introduced the "include page ID in cHash calculation" part. However, I know what you mean:
Check 1. if a cHash is present it MUST match, otherwise 404/disable Cache
Check 2. otherwise check if there are relevant parameters that would need a cHash

This is how it's in v9.

I guess we'd need to do a
if ($cHash && !$hasRelevantParameters) {
// skip cHash validation and remove cHash from GET vars
} elseif (cHash and hash_comparision) {
Check 1
} elseif (nocHash && $hasRelevantParameters) {
Check 2
}

question would be if we'd disable caching then or fallback to "pretent there was no cHash"

I think the issue was mitigated when we introduced the "include page ID in cHash calculation" part

No, it was not. cHash can still be supplied. But if the code works like you described (=checking relevant parameters), then it should be fine in v9. Not in older versions though. The patch for them was submitted by me long time ago...

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895