Project

General

Profile

Actions
Copy link

Bug #41120

closed

Hardcoded fileadmin directory in Import-Export

Added by Pascal Oberhaensli over 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-09-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

$fileAdminDir is hardcoded in t3lib\class.t3lib_softrefproc.php and typo3\sysext\impexp\class.tx_impexp.php

$TYPO3_CONF_VARS['BE']['fileadminDir'] should be used instead

If $fileAdminDir is 'fileadmin' and you have changed your fileadminDir in the localconf.php the Reference Index cannot work anymore. Ref column in the filelist for your files will then be empty.

Related issues 1 (0 open — 1 closed)

Precedes TYPO3 Core - Bug #42454: Fix usage of fileadminDirClosed2012-10-28

Actions
Actions
Copy link
 #1

Updated by Pascal Oberhaensli over 11 years ago

$fileadminFolderName is the var in typo3\sysext\impexp\class.tx_impexp.php

Actions
Copy link
 #2

Updated by Oliver Hader over 11 years ago

  • Status changed from New to Accepted

Still valid up to version 6.0.
Would you like to create a patch for that, setting the class member variable with the TYPO3_CONF_VARS value in the constructor of that class (creating the __construct() method is required as well)?
See http://wiki.typo3.org/Git if you need a quick guide with Git or just get back to me.

Actions
Copy link
 #3

Updated by Oliver Hader over 11 years ago

  • Subject changed from $fileAdminDir hardcoded to Hardcoded fileadmin directory in Import-Export
Actions
Copy link
 #4

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15378

Actions
Copy link
 #5

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15378

Actions
Copy link
 #6

Updated by Gerrit Code Review over 11 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15480

Actions
Copy link
 #7

Updated by Thomas Löffler over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #8

Updated by Gerrit Code Review over 11 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15480

Actions
Copy link
 #9

Updated by Oliver Hader over 11 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #10

Updated by Christian Kuhn over 11 years ago

The 4.6 and 4.5 backports should NOT be done, the patch is not important enough for that, especially considering the regression of #42454

Actions
Copy link
 #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF