Bug #42051

Javascript labels are not escaped, resulting in a bug when previewing with a french BE

Added by Fronzes Philippe about 9 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2012-10-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi,

This bug was first posted here: http://lists.typo3.org/pipermail/typo3-english/2012-March/079796.html

I have got the same on a 4.5.19.

In function indexAction(), in typo3/sysext/workspaces/classes/controller/PreviewController.php, labels are not escaped for 'visualPreview' .... 'modeHbox'.
Particularly, in french, the label for "workspacePreviewDetail" contains a single quote, resulting in a javascript bug.

These labels should go through addInlineLanguageLabel or equivalent from the class t3lib_pageRenderer.

I will try to submit a patch later.

#1

Updated by Fronzes Philippe about 9 years ago

I think this is the same issue than http://forge.typo3.org/issues/39339#note-5

#2

Updated by Francois Suter about 9 years ago

It's the same issue indeed. I just stumbled on it too. I have a patch nearly ready for master.

#3

Updated by Gerrit Code Review about 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15740

#4

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15740

#5

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15740

#6

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch workspaces_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15758

#7

Updated by Francois Suter about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:6ca05a7d92c028d415cf880ab5c83a2e6eeaa9f3.

#8

Updated by Gerrit Code Review about 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 4.6 has been pushed to the review server.
It is available at http://review.typo3.org/15762

#9

Updated by Gerrit Code Review about 9 years ago

Patch set 1 for branch 4.5 has been pushed to the review server.
It is available at http://review.typo3.org/15763

#10

Updated by Francois Suter about 9 years ago

  • Status changed from Under Review to Resolved

Applied in changeset commit:a620e779d1ddd7ac2bb8fcf0b9ad0aa2b109be0a.

#11

Updated by Michael Stucki almost 8 years ago

  • Category changed from Bugs to Workspaces
#12

Updated by Michael Stucki almost 8 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
#13

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF