Bug #42111

Lockfiles retain on sql error, no further versioning is possible for affected record in the fututer

Added by Michael Schramm about 8 years ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2012-10-18
Due date:
% Done:

100%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

if you try to publish a page and i.e a sql error occurs there will be retain a lockfile for this page so that even if the error is removed the file stays locked in PATH_site.'typo3temp/swap_locking/ an can't be published

\typo3\sysext\version\class.tx_version_tcemain.php
...
// Lock file name:
$lockFileName = PATH_site.'typo3temp/swap_locking/' . $table . ':' . $id . '.ser';

if (!@is_file($lockFileName) )    {
...

After deleting the lockfile in PATH_site.'typo3temp/swap_locking/ everything works fine again

Is ist for example possible to add a max lifetime to the lockfile and request in like
if (!@is_file($lockFileName) && $maxLockFileLifetime > now() ) {

Associated revisions

Revision a51eff36 (diff)
Added by Benni Mack 7 months ago

[BUGFIX] Check for a maximum lifetime of 1h for workspace swap locking

Resolves: #42111
Releases: master
Change-Id: Ie9b35fb8a32f18f3be6ccd62b87e93e71d6cdea9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63770
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Michael Stucki almost 7 years ago

  • Category changed from Bugs to Workspaces

#2 Updated by Michael Stucki almost 7 years ago

  • Project changed from Workspaces & Versioning to TYPO3 Core
  • Category changed from Workspaces to Workspaces

#3 Updated by Mathias Schreiber almost 6 years ago

  • Target version set to 7.5

#4 Updated by Benni Mack about 5 years ago

  • Target version changed from 7.5 to 7 LTS

#5 Updated by Mathias Schreiber almost 5 years ago

  • Target version deleted (7 LTS)

#6 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63770

#7 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63770

#8 Updated by Gerrit Code Review 7 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63770

#9 Updated by Benni Mack 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF