Bug #43606

Wrong path when compressing and merging external js files

Added by Simon Schaufelberger almost 7 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-12-05
Due date:
% Done:

100%

TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

in t3lib_compressor on line 319 the path for external files is wrong (as parameter for the method t3lib_div::getUrl).
in my case the path looks like this:

C:/xampp/htdocs/http://html5shim.googlecode.com/svn/trunk/html5.js

the problem at this line is that the rootpath ($this->rootPath) is always added even for external files.

to test:

config.compressJs = 1
config.concatenateJs = 1

page = PAGE
page {
    includeJS {
        html5 = http://html5shim.googlecode.com/svn/trunk/html5.js
        html5 {
            external = 1
        }
    }
}

Related issues

Related to TYPO3 Core - Bug #29695: t3lib_Compressor fails with external files Closed 2011-09-12
Related to TYPO3 Core - Bug #50815: t3lib_compressor doesn't fully sanitize filepath Closed 2013-08-06

History

#1 Updated by Tobias Liebig almost 7 years ago

Should be easy to solve.

Hint:
in v4.7: t3lib_Compressor
in v6.x: \TYPO3\CMS\Core\ResourceResourceCompressor, function createMergedFile

#2 Updated by Zbigniew Jacko over 5 years ago

  • % Done changed from 0 to 100

#3 Updated by Ernesto Baschny over 5 years ago

  • Status changed from New to Needs Feedback
  • Is Regression set to No

Does #29695 solved your issue already, Simon?

#4 Updated by Simon Schaufelberger over 5 years ago

will test in in the next few days

#5 Updated by Alexander Opitz over 5 years ago

Hi Simon, did you already tested the behavior?

#6 Updated by Simon Schaufelberger about 5 years ago

yes, works as expected. issue can be closed.

#7 Updated by Alexander Opitz about 5 years ago

  • Status changed from Needs Feedback to Closed

Thanks for testing.

Also available in: Atom PDF