Bug #44073

Checksum needs to be updated after file processing

Added by Helmut Hummel over 8 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2012-12-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When recreating an already processed file the LocalImageProcessor
updates the width, height and filesize of the new image but not
the checksum.

Because of that the file will be deleted in FileProcessingService
when $processedFile->isProcessed() is called. Since the checksum
is wrong this call assumes that the file needs to be recreated and
deletes the "old" file on the go.

This will lead to an exception in this request, when getPublicUrl is
called on this object.

Since the checksum is not only based on the processing configuration
but also on the graphic configuration, these exceptions only occur
when the graphic configuration is changes (e.g. in a deploy scenario).

The problem can easily be reproduced by enforcing
a change of the GFX configuration e.g. by adding the
following line to AdditionalConfiguration.php

$GLOBALS['TYPO3_CONF_VARS']['GFX']['foo'] = uniqid()

Then an exception is thrown for every processed file on every request.


Related issues

Related to TYPO3 Core - Bug #45168: Wrong image displayed in FE if not resizedClosedAndreas Wolf2013-02-05

Actions
Related to TYPO3 Core - Bug #44616: Image caching broken for im_noScaleUp = 1ClosedAndreas Wolf2013-01-17

Actions
Related to TYPO3 Core - Bug #44645: Preview images don't get a new filename after overwriting with updated fileClosed2013-01-18

Actions
#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17207

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/17208

#3

Updated by Helmut Hummel over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Andreas Wolf over 8 years ago

The triggers a sham bug - the filename of the processed file is not updated, so it seems as if the relation between the processed file and the original file is broken. See #45168 and #44616 for details.

Don't see this as a blame, this is just a note so nobody searches for this "bug" again for hours :-/.

#5

Updated by Benni Mack almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF