Bug #44645

Preview images don't get a new filename after overwriting with updated file

Added by Marcel Burkhalter almost 8 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-01-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

Steps to reproduce:
- Upload a file in the filelist
- Check filename of preview image (e.g.: preview_102455_4635_924f2e40ad.jpg)
- Overwrite with a file with the same filename but different file content
- Check preview filename again --> it stays the same
--> We've seen caching issues with IE9 because of this

As a workaround we added the following config in the .htaccess file:

<FilesMatch "^preview_.*\.(jpe?g|png|gif)$">
  FileETag none
  <ifModule mod_headers.c>
    Header unset ETag
    Header set Cache-Control "max-age=0, no-cache, no-store, must-revalidate" 
    Header set Pragma "no-cache" 
    Header set Expires "Wed, 11 Jan 1984 05:00:00 GMT" 
  </ifModule>
</FilesMatch>

This worked for the filelist: we now see the correct preview image directly after overwriting without manual browser reload or browser cache clearing.
BUT: In the list or page module we still see the old preview image until the IE9 tab has been reloaded (without the .htaccess rule we had to clear the browser cache to see the updated preview image). Of course this all works flawlessly with FF :)


Related issues

Related to TYPO3 Core - Task #44550: Preview image and database entry not deleted when deleting a FAL fileClosed2013-01-15

Actions
Related to TYPO3 Core - Bug #44073: Checksum needs to be updated after file processingClosed2012-12-17

Actions
Related to TYPO3 Core - Bug #44105: Image size does not get updatedClosed2012-12-19

Actions
Related to TYPO3 Core - Bug #56539: Update/Change file-hash when file is replaced with a new one with the filelistClosed2014-03-04

Actions
#1

Updated by Andreas Wolf almost 8 years ago

  • Status changed from New to Accepted

I suggest to include the timestamp or SHA1 hash in the name generation for the processed file. This should fix this and other issues around updating processed files. I'll have to check again though what is currently used for filename generation - maybe there's also a bug in there.

#2

Updated by Andreas Wolf almost 8 years ago

  • Project changed from File Abstraction Layer to TYPO3 Core
#3

Updated by Andreas Wolf almost 8 years ago

  • Category set to File Abstraction Layer (FAL)
  • Assignee set to Andreas Wolf
  • Target version set to 6.0.2
  • TYPO3 Version set to 6.0
#4

Updated by Andreas Wolf almost 8 years ago

This results from the filename not being adjusted in the patch for #44073. We'll have to tackle this.

#5

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170

#6

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170

#7

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170

#8

Updated by Steffen Ritter about 7 years ago

  • Status changed from Under Review to Needs Feedback
  • Assignee deleted (Andreas Wolf)
  • Is Regression set to No

the original patch set was abendonded

#9

Updated by Alexander Opitz over 6 years ago

  • Target version deleted (6.0.2)

Does the issue still exists? IMHO this was fixed in another issue.

#10

Updated by Sebastian Fischer over 6 years ago

I can confirm that this problem still exists in current master

#11

Updated by Alexander Opitz about 6 years ago

  • Status changed from Needs Feedback to New
#12

Updated by Ingo Schmitt almost 6 years ago

  • TYPO3 Version changed from 6.0 to 6.2
  • Sprint Focus set to On Location Sprint
#13

Updated by Andrea Herzog-Kienast almost 6 years ago

  • Target version set to 7.1 (Cleanup)
#14

Updated by Andrea Herzog-Kienast almost 6 years ago

"BUT: In the list or page module we still see the old preview image until the IE9 tab has been reloaded (without the .htaccess rule we had to clear the browser cache to see the updated preview image). Of course this all works flawlessly with FF :)"

This is not the case in 7.1 - behavoir is as expected.

#15

Updated by Ingo Schmitt almost 6 years ago

  • Complexity set to medium

Solution could be to calculate the hash for the preview also by the filehash.

#16

Updated by Ingo Schmitt almost 6 years ago

  • Status changed from New to In Progress
#17

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530

#18

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530

#19

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530

#20

Updated by Ruud Silvrants almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#21

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36898

#22

Updated by Ruud Silvrants almost 6 years ago

  • Status changed from Under Review to Resolved
#23

Updated by Anja Leichsenring almost 5 years ago

  • Sprint Focus deleted (On Location Sprint)
#24

Updated by Riccardo De Contardi about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF