Bug #44645
closedPreview images don't get a new filename after overwriting with updated file
100%
Description
Steps to reproduce:
- Upload a file in the filelist
- Check filename of preview image (e.g.: preview_102455_4635_924f2e40ad.jpg)
- Overwrite with a file with the same filename but different file content
- Check preview filename again --> it stays the same
--> We've seen caching issues with IE9 because of this
As a workaround we added the following config in the .htaccess file:
<FilesMatch "^preview_.*\.(jpe?g|png|gif)$"> FileETag none <ifModule mod_headers.c> Header unset ETag Header set Cache-Control "max-age=0, no-cache, no-store, must-revalidate" Header set Pragma "no-cache" Header set Expires "Wed, 11 Jan 1984 05:00:00 GMT" </ifModule> </FilesMatch>
This worked for the filelist: we now see the correct preview image directly after overwriting without manual browser reload or browser cache clearing.
BUT: In the list or page module we still see the old preview image until the IE9 tab has been reloaded (without the .htaccess rule we had to clear the browser cache to see the updated preview image). Of course this all works flawlessly with FF :)
Updated by Andreas Wolf over 11 years ago
- Status changed from New to Accepted
I suggest to include the timestamp or SHA1 hash in the name generation for the processed file. This should fix this and other issues around updating processed files. I'll have to check again though what is currently used for filename generation - maybe there's also a bug in there.
Updated by Andreas Wolf over 11 years ago
- Project changed from 1401 to TYPO3 Core
Updated by Andreas Wolf over 11 years ago
- Category set to File Abstraction Layer (FAL)
- Assignee set to Andreas Wolf
- Target version set to 6.0.2
- TYPO3 Version set to 6.0
Updated by Andreas Wolf over 11 years ago
This results from the filename not being adjusted in the patch for #44073. We'll have to tackle this.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170
Updated by Gerrit Code Review over 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170
Updated by Steffen Ritter almost 11 years ago
- Status changed from Under Review to Needs Feedback
- Assignee deleted (
Andreas Wolf) - Is Regression set to No
the original patch set was abendonded
Updated by Alexander Opitz over 10 years ago
- Target version deleted (
6.0.2)
Does the issue still exists? IMHO this was fixed in another issue.
Updated by Sebastian Fischer over 10 years ago
I can confirm that this problem still exists in current master
Updated by Alexander Opitz about 10 years ago
- Status changed from Needs Feedback to New
Updated by Ingo Schmitt almost 10 years ago
- TYPO3 Version changed from 6.0 to 6.2
- Sprint Focus set to On Location Sprint
Updated by Andrea Herzog-Kienast over 9 years ago
- Target version set to 7.1 (Cleanup)
Updated by Andrea Herzog-Kienast over 9 years ago
"BUT: In the list or page module we still see the old preview image until the IE9 tab has been reloaded (without the .htaccess rule we had to clear the browser cache to see the updated preview image). Of course this all works flawlessly with FF :)"
This is not the case in 7.1 - behavoir is as expected.
Updated by Ingo Schmitt over 9 years ago
- Complexity set to medium
Solution could be to calculate the hash for the preview also by the filehash.
Updated by Ingo Schmitt over 9 years ago
- Status changed from New to In Progress
Updated by Gerrit Code Review over 9 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530
Updated by Ruud Silvrants over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5b9e6b818b0a3f0d518665529c883f452e2ce21b.
Updated by Gerrit Code Review over 9 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36898
Updated by Ruud Silvrants over 9 years ago
- Status changed from Under Review to Resolved
Applied in changeset 251e52059e13c97ec1a294ee2bd258a9bd5532c4.
Updated by Anja Leichsenring almost 9 years ago
- Sprint Focus deleted (
On Location Sprint)
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed