Project

General

Profile

Actions

Bug #44645

closed

Preview images don't get a new filename after overwriting with updated file

Added by Marcel Burkhalter about 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-01-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

Steps to reproduce:
- Upload a file in the filelist
- Check filename of preview image (e.g.: preview_102455_4635_924f2e40ad.jpg)
- Overwrite with a file with the same filename but different file content
- Check preview filename again --> it stays the same
--> We've seen caching issues with IE9 because of this

As a workaround we added the following config in the .htaccess file:

<FilesMatch "^preview_.*\.(jpe?g|png|gif)$">
  FileETag none
  <ifModule mod_headers.c>
    Header unset ETag
    Header set Cache-Control "max-age=0, no-cache, no-store, must-revalidate" 
    Header set Pragma "no-cache" 
    Header set Expires "Wed, 11 Jan 1984 05:00:00 GMT" 
  </ifModule>
</FilesMatch>

This worked for the filelist: we now see the correct preview image directly after overwriting without manual browser reload or browser cache clearing.
BUT: In the list or page module we still see the old preview image until the IE9 tab has been reloaded (without the .htaccess rule we had to clear the browser cache to see the updated preview image). Of course this all works flawlessly with FF :)


Related issues 4 (0 open4 closed)

Related to TYPO3 Core - Task #44550: Preview image and database entry not deleted when deleting a FAL fileClosed2013-01-15

Actions
Related to TYPO3 Core - Bug #44073: Checksum needs to be updated after file processingClosed2012-12-17

Actions
Related to TYPO3 Core - Bug #44105: Image size does not get updatedClosed2012-12-19

Actions
Related to TYPO3 Core - Bug #56539: Update/Change file-hash when file is replaced with a new one with the filelistClosed2014-03-04

Actions
Actions #1

Updated by Andreas Wolf about 11 years ago

  • Status changed from New to Accepted

I suggest to include the timestamp or SHA1 hash in the name generation for the processed file. This should fix this and other issues around updating processed files. I'll have to check again though what is currently used for filename generation - maybe there's also a bug in there.

Actions #2

Updated by Andreas Wolf about 11 years ago

  • Project changed from 1401 to TYPO3 Core
Actions #3

Updated by Andreas Wolf about 11 years ago

  • Category set to File Abstraction Layer (FAL)
  • Assignee set to Andreas Wolf
  • Target version set to 6.0.2
  • TYPO3 Version set to 6.0
Actions #4

Updated by Andreas Wolf about 11 years ago

This results from the filename not being adjusted in the patch for #44073. We'll have to tackle this.

Actions #5

Updated by Gerrit Code Review about 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170

Actions #6

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170

Actions #7

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19170

Actions #8

Updated by Steffen Ritter over 10 years ago

  • Status changed from Under Review to Needs Feedback
  • Assignee deleted (Andreas Wolf)
  • Is Regression set to No

the original patch set was abendonded

Actions #9

Updated by Alexander Opitz about 10 years ago

  • Target version deleted (6.0.2)

Does the issue still exists? IMHO this was fixed in another issue.

Actions #10

Updated by Sebastian Fischer almost 10 years ago

I can confirm that this problem still exists in current master

Actions #11

Updated by Alexander Opitz over 9 years ago

  • Status changed from Needs Feedback to New
Actions #12

Updated by Ingo Schmitt about 9 years ago

  • TYPO3 Version changed from 6.0 to 6.2
  • Sprint Focus set to On Location Sprint
Actions #13

Updated by Andrea Herzog-Kienast about 9 years ago

  • Target version set to 7.1 (Cleanup)
Actions #14

Updated by Andrea Herzog-Kienast about 9 years ago

"BUT: In the list or page module we still see the old preview image until the IE9 tab has been reloaded (without the .htaccess rule we had to clear the browser cache to see the updated preview image). Of course this all works flawlessly with FF :)"

This is not the case in 7.1 - behavoir is as expected.

Actions #15

Updated by Ingo Schmitt about 9 years ago

  • Complexity set to medium

Solution could be to calculate the hash for the preview also by the filehash.

Actions #16

Updated by Ingo Schmitt about 9 years ago

  • Status changed from New to In Progress
Actions #17

Updated by Gerrit Code Review about 9 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530

Actions #18

Updated by Gerrit Code Review about 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530

Actions #19

Updated by Gerrit Code Review about 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36530

Actions #20

Updated by Ruud Silvrants about 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #21

Updated by Gerrit Code Review about 9 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/36898

Actions #22

Updated by Ruud Silvrants about 9 years ago

  • Status changed from Under Review to Resolved
Actions #23

Updated by Anja Leichsenring about 8 years ago

  • Sprint Focus deleted (On Location Sprint)
Actions #24

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF