Task #44965

Cleanups for CSS Styled Content

Added by Sebastian Michaelsen almost 7 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2013-01-30
Due date:
% Done:

100%

TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

  • Remove "@todo Define visibility" annotations from the render_* methods. They are called from TS, they need to be public.
  • Remove unused variables from the CssStyledContentController
  • Don't pass the constants borderColor and rowSpace to tt_content.image any more, they are not used there.

Related issues

Blocked by TYPO3 Core - Task #44963: Create CSS Styled Content TypoScript configuration for v6.0 Closed 2013-01-30

Associated revisions

Revision 03e97a77 (diff)
Added by Sebastian Michaelsen almost 7 years ago

[TASK] Cleanups for CSS Styled Content

  • Remove "@todo Define visibility" annotations from the render_*
    methods. They are called from TS, they need to be public.
  • Remove unused variables from the CssStyledContentController
  • Don't pass the constants borderColor and rowSpace to
    tt_content.image any more, they are not used there

Resolves: #44965
Releases: 6.1
Change-Id: Ia6ee55754c9af976952274e22c01565f15ec2038
Reviewed-on: https://review.typo3.org/17834
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn

History

#1 Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17834

#2 Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17834

#3 Updated by Sebastian Michaelsen almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review almost 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master_new has been pushed to the review server.
It is available at https://review.typo3.org/18589

#5 Updated by Christian Kuhn almost 7 years ago

  • Status changed from Under Review to Resolved

#6 Updated by Oliver Hader almost 7 years ago

  • Target version changed from 6.1.0 to 6.1.0-alpha1

#7 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF