Task #44965

Cleanups for CSS Styled Content

Added by Sebastian Michaelsen over 8 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2013-01-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

  • Remove "@todo Define visibility" annotations from the render_* methods. They are called from TS, they need to be public.
  • Remove unused variables from the CssStyledContentController
  • Don't pass the constants borderColor and rowSpace to tt_content.image any more, they are not used there.

Related issues

Blocked by TYPO3 Core - Task #44963: Create CSS Styled Content TypoScript configuration for v6.0Closed2013-01-30

Actions
#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17834

#2

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/17834

#3

Updated by Sebastian Michaelsen over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master_new has been pushed to the review server.
It is available at https://review.typo3.org/18589

#5

Updated by Christian Kuhn over 8 years ago

  • Status changed from Under Review to Resolved
#6

Updated by Oliver Hader over 8 years ago

  • Target version changed from 6.1.0 to 6.1.0-alpha1
#7

Updated by Riccardo De Contardi almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF