Task #45148

show_item does not consider workspace references

Added by Oliver Hader over 8 years ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
-
Start date:
2013-02-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

typo3/show_item.php does not consider workspace references, that might be IRRE or plain MM.
The reason is the the overlay still uses the uid of the original record (which is the placeholder on new workspace records).
The fix is to use the processed record index "_ORIG_uid" instead of "uid" here, if available.


Files

references_example.png (13.6 KB) references_example.png Oliver Hader, 2014-01-27 09:42
#1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/18006

#2

Updated by Oliver Hader over 7 years ago

  • Parent task set to #54853
  • Is Regression set to No
#3

Updated by Oliver Hader over 7 years ago

Needs to be rechecked, once the workspace fixes for IRRE/MM are integrated.

This screenshot shows, where the accordant workspace elements should be visualized (if any):

#4

Updated by Oliver Hader about 7 years ago

  • Status changed from On Hold to Accepted
  • Target version deleted (4.5.23)
  • TYPO3 Version changed from 4.7 to 6.2
#5

Updated by Mathias Schreiber over 5 years ago

  • Description updated (diff)
#6

Updated by Oliver Hader over 5 years ago

  • Category changed from Backend User Interface to Workspaces
#7

Updated by Benni Mack over 3 years ago

  • Parent task deleted (#54853)
#8

Updated by Oliver Hader about 1 year ago

Still valid in v9.5.14

#9

Updated by Gerrit Code Review 9 months ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65453

#10

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65453

#11

Updated by Christian Kuhn 9 months ago

Reproduce with irre_tutorial:

Preparation:
Enable the irre_tutorial extension for an instance. Most simple way is to create a link in typo3conf/ext to the extension:

ll typo3conf/ext/
irre_tutorial -> ../../typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/

Load the extension via ext manager, db stuff, clean caches.

Test case:
  • Live workspace
  • Add a page
  • Add a content element -> tab irre_tutorial
  • Add Hotels (1nff) 'hotel 1' as inline child to content element
  • Add 'offer 1 1' as inline child to 'hotel 1'
  • Switch to workspace
  • Edit the content element
  • Add 'offer 1 2' as inline child to 'hotel 1'
  • Go to list module
  • Extended mode
  • 'i' button on 'Hotel 1'
    -> "References from this item" shows only 'offer 1 1' but should also show 'offer 1 2'
#12

Updated by Christian Kuhn 9 months ago

Another use case: Have a content element with an image in live and add a second image in workspace -> the 'i' modal shows only the first images in the reference list.

#13

Updated by Christian Kuhn 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#14

Updated by Gerrit Code Review 9 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65474

#15

Updated by Christian Kuhn 8 months ago

  • Status changed from Under Review to Resolved
#16

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF