Project

General

Profile

Actions

Bug #45183

closed

Condition globalString is not true if left and right of condition are empty strings

Added by Marc Bastian Heinrichs about 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
TypoScript
Target version:
-
Start date:
2013-02-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

current workaround is using globalVar, which works for equals


Files

45183.diff (847 Bytes) 45183.diff Marc Bastian Heinrichs, 2013-02-06 10:07

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #53564: Backport function getAccessibleMockForAbstractClass from FlowClosed2013-11-12

Actions
Related to TYPO3 Core - Bug #59344: Condition globalString with LIT: is not true if left and right of condition are empty stringsClosedMarc Bastian Heinrichs2014-06-04

Actions
Actions #1

Updated by Thorsten Kahler about 11 years ago

  • Status changed from New to Needs Feedback
  • Assignee set to Marc Bastian Heinrichs

Code examples would have made the issue easier to understand. I assume the following:

[globalString = = ]

is false while

[globalVar = = ]

is true?

Or does the issue occur when the left value of the comparison evaluates to an empty string? Like this:

[globalString = GP:someNonExistentGetParameter = ]
Actions #2

Updated by Marc Bastian Heinrichs about 11 years ago

Thorsten Kahler wrote:

Code examples would have made the issue easier to understand.

you are right :-)

I assume the following:

No

Or does the issue occur when the left value of the comparison evaluates to an empty string? Like this:

[...]

yep, meant this or e.g.

[globalString = GP:theValueOfThisParameterIsEmpty = ]

Fixed this for the moment via attached patch.

I ever used globalVar for this comparison, but now it's time to fix this, because globalVar isn't for string comparison, right?

Btw.: it works in globalVar because the equals is the only case in function compareNumber() where no doubleval() is called on the rightValue, what is inconsistent.

Actions #3

Updated by Thorsten Kahler about 11 years ago

  • Status changed from Needs Feedback to Accepted
Actions #4

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21979

Actions #5

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22096

Actions #6

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27249

Actions #7

Updated by Marc Bastian Heinrichs about 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27250

Actions #9

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27251

Actions #10

Updated by Marc Bastian Heinrichs almost 10 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF