Bug #45183
closedCondition globalString is not true if left and right of condition are empty strings
100%
Description
current workaround is using globalVar, which works for equals
Files
Updated by Thorsten Kahler almost 12 years ago
- Status changed from New to Needs Feedback
- Assignee set to Marc Bastian Heinrichs
Code examples would have made the issue easier to understand. I assume the following:
[globalString = = ]
is false while
[globalVar = = ]
is true?
Or does the issue occur when the left value of the comparison evaluates to an empty string? Like this:
[globalString = GP:someNonExistentGetParameter = ]
Updated by Marc Bastian Heinrichs almost 12 years ago
- File 45183.diff 45183.diff added
Thorsten Kahler wrote:
Code examples would have made the issue easier to understand.
you are right :-)
I assume the following:
No
Or does the issue occur when the left value of the comparison evaluates to an empty string? Like this:
[...]
yep, meant this or e.g.
[globalString = GP:theValueOfThisParameterIsEmpty = ]
Fixed this for the moment via attached patch.
I ever used globalVar for this comparison, but now it's time to fix this, because globalVar isn't for string comparison, right?
Btw.: it works in globalVar because the equals is the only case in function compareNumber() where no doubleval() is called on the rightValue, what is inconsistent.
Updated by Thorsten Kahler almost 12 years ago
- Status changed from Needs Feedback to Accepted
Updated by Gerrit Code Review over 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21979
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22096
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27249
Updated by Marc Bastian Heinrichs almost 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 06bf27df49a2ae3b1de49e64169139ac5c449681.
Updated by Gerrit Code Review almost 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-0 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27250
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_4-5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27251
Updated by Marc Bastian Heinrichs over 10 years ago
- Status changed from Under Review to Resolved
Applied in changeset db90a2676cd96e34203713545d98be2c5a891a4a.