Bug #45945
closed
optionSplit din't work well when using noTrimWrap special configuration
100%
Description
Hi there,
When using optionSplit by calling splitConfArray function, there might be a bug when setting noTrimWrap to "|| |" or "| ||".
an easy correction is to add a special condition for each segments:
File: t3lib/class.t3lib_tstemplate.php
for 4.5:
L. 1135: change to if ($main[0] && $cKey != 'noTrimWrap') {
L. 1139: change to if ($main[1] && $cKey != 'noTrimWrap') {
L. 1143: change to if ($main[2] && $cKey != 'noTrimWrap') {
for 4.7:
L. 1009: change to if ($main[0] && $cKey != 'noTrimWrap') {
L. 1013: change to if ($main[1] && $cKey != 'noTrimWrap') {
L. 1017: change to if ($main[2] && $cKey != 'noTrimWrap') {
Updated by Stefan Galinski about 11 years ago
Hi Christophe,
As you already found a working solution, can you please finalize your contribution by pushing this to our review system (http://review.typo3.org)? The workflow is documented here: http://wiki.typo3.org/Contribution_Walkthrough_Tutorials
Updated by Christophe Monard about 11 years ago
a better working correction:
TYPO3 4.7
L.997:
replace
if (!strstr($val, '|*|') && !strstr($val, '||')) {
by
if ($cKey == 'noTrimWrap' || (!strstr($val, '|*|') && !strstr($val, '||'))) {
Woking on the review for submitting
Updated by Gerrit Code Review about 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/18825
Updated by Wouter Wolters over 9 years ago
- Status changed from Under Review to New
- Is Regression set to No
Updated by Christophe Monard over 9 years ago
- % Done changed from 0 to 100
Not needed anymore since 6.1 branch and the introduction of the splitChar properties.
Updated by Riccardo De Contardi over 9 years ago
so this could be set as closed?
Updated by Christophe Monard over 9 years ago
Yes, i think no new fonctionnality should be planned for 4.5 branch.
Updated by Mathias Schreiber about 9 years ago
- Status changed from New to Closed