Project

General

Profile

Actions

Bug #46497

closed

FAL Upgrade Wizard does not set the pid / sys_file_reference is placed on rootlevel

Added by Benni Mack about 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-03-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The sys_file_reference records are originally set to be placed on rootLevel, the upgrade wizard does exactly that.

However, the concept in this case is flawed
  • When creating new sys_file_reference records via IRRE, the sys_file_reference is stored on the page
  • When copying moving e.g. a tt_content record, all its child elements are placed on that new page as well (so this works)
  • rootLevel restriction is not needed in this case
The patch does the following:
  • Modify the existing upgrade wizard to place the sys_file_references on the pages of the foreign tables (tt_content pid)
  • the rootLevel flag for sys_file_reference is removed
  • Add a new upgrade wizard is added to ensure the integrity of the sys-file-reference pids

Related issues 1 (0 open1 closed)

Is duplicate of TYPO3 Core - Bug #44752: migrated files are not in filelist (tt_content-images , pages-media) - be_user (non admin !?)Closed2013-01-23

Actions
Actions #1

Updated by Gerrit Code Review about 11 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19130

Actions #2

Updated by Andreas Wolf about 11 years ago

  • Project changed from 1401 to TYPO3 Core
  • Category deleted (Migration)
  • Target version deleted (6.1)
Actions #3

Updated by Andreas Wolf about 11 years ago

  • Category set to File Abstraction Layer (FAL)
  • Target version set to 6.0.5
  • TYPO3 Version set to 6.0
Actions #4

Updated by Henrik Ziegenhain about 11 years ago

Looks good so far. Simon Schick discovered already one thing that should be respected.

But, I think we need this also for 6.0 (as a simple bugfix without a new Upgrade Wizard) - currently it`s not possible to update an existing site to 6.0 without running an external script (the one from #44752) after the update to show the files also for editors.

Edit: Andreas was faster :) Thank you.

Actions #5

Updated by Gerrit Code Review about 11 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/19130

Actions #6

Updated by Gerrit Code Review about 11 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/19216

Actions #7

Updated by Benni Mack about 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF