Bug #46610

ElementBrowser must not use dirname() on identifier

Added by Georg Ringer about 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2013-03-23
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

There is such a code twice in Elementbrowser

// It's a file
// @todo: find the parent folder, right now done a bit ugly, because the file does not
// support finding the parent folder of a file on purpose
$folderIdentifier = dirname($fileOrFolderObject->getIdentifier());

this breaks every driver which is not based on directories


Related issues

Related to TYPO3 Core - Bug #45859: Element Browser stops workingClosedBenni Mack2013-02-26

Actions
#1

Updated by Ernesto Baschny over 7 years ago

  • Status changed from New to Accepted

The comment says it all. :)

I guess we need further API. The Storage has to ask the Driver is it is "hierarchical" and only then provide a "Folder" hierarchy in the first place. We already have an AbstractHierarchicalFilesystemDriver superclass on top of LocalDriver.

On the other hand we do not have an alterantive Element Browser for non-hierarchical Drivers yet.

#2

Updated by Steffen Ritter over 7 years ago

  • Is Regression set to No

I added API for resolving a folderIdentifier based on a file identifier...
this could be used!

#3

Updated by Sebastian Fischer about 7 years ago

Cant find the code above in the current master. Does this problem still exists?

#4

Updated by Frans Saris almost 7 years ago

  • Status changed from Accepted to Closed

This is already resolved with some other cleanup patch.

Also available in: Atom PDF