Bug #46610
closed
ElementBrowser must not use dirname() on identifier
Added by Georg Ringer over 11 years ago.
Updated over 10 years ago.
Category:
File Abstraction Layer (FAL)
Description
There is such a code twice in Elementbrowser
// It's a file
// @todo: find the parent folder, right now done a bit ugly, because the file does not
// support finding the parent folder of a file on purpose
$folderIdentifier = dirname($fileOrFolderObject->getIdentifier());
this breaks every driver which is not based on directories
- Status changed from New to Accepted
The comment says it all. :)
I guess we need further API. The Storage has to ask the Driver is it is "hierarchical" and only then provide a "Folder" hierarchy in the first place. We already have an AbstractHierarchicalFilesystemDriver superclass on top of LocalDriver.
On the other hand we do not have an alterantive Element Browser for non-hierarchical Drivers yet.
I added API for resolving a folderIdentifier based on a file identifier...
this could be used!
Cant find the code above in the current master. Does this problem still exists?
- Status changed from Accepted to Closed
This is already resolved with some other cleanup patch.
Also available in: Atom
PDF