Project

General

Profile

Actions

Bug #46829

closed

felogin :: Return to login form link not working

Added by Arun Chandran almost 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Category:
felogin
Target version:
Start date:
2013-04-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
5.4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I've an issue with felogin system extension.I am using typo3 v 6.0.4.
The link of "Return to login form" inside the Forgot Your Password page not working (Link to the forgot password page itself). Also this link is missing in Reset password success message display, password does not exists message display etc.
And this link not working in any stage of this extesion. I mean when resetting password,change password etc.
I've compared the extesion code with older version.

Actions #1

Updated by Jigal van Hemert almost 11 years ago

  • Category set to felogin
Actions #2

Updated by Jigal van Hemert almost 11 years ago

  • Status changed from New to Needs Feedback

Can you give your configuration and page structure? In my test installation I couldn't replicate the problem. All links back to the login form were working correctly.

Actions #3

Updated by Arun Chandran almost 11 years ago

This is my configuration part. Nothing more.

plugin.tx_felogin_pi1 {
storagePid = 26
newPasswordMinLength = 3
showPermaLogin = 1
exposeNonexistentUserInForgotPasswordDialog = 1
}

I've make some modifications in the file /typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php in my test installation. Then its working fine.

Line number 743 to 753 posted here and my changes are highlighted.

protected function getPageLink($label, $piVars, $returnUrl = FALSE, $noPreserve=1) {
$additionalParams = '';
if (count($piVars)) {
foreach ($piVars as $key => $val) {
$additionalParams .= '&' . $key . '=' . $val;
}
}
// Should GETvars be preserved?
if ($this->conf['preserveGETvars'] && $noPreserve) {
$additionalParams .= $this->getPreserveGetVars();
}

And also $markerArray['###BACKLINK_LOGIN###'] is empty in several cases.
So that I've added the following code in line number 214 of the same file.

$markerArray['###BACKLINK_LOGIN###'] = $this->getPageLink($this->pi_getLL('ll_forgot_header_backToLogin', '', 1), array(),FALSE,0);

I've noted one more issue, if we login with invalid username and password, the form does not shows the error message. From my investigations, i can understood this is because of \TYPO3\CMS\Core\Utility\HttpUtility::redirect($this->redirectUrl); in the line number 162 of the controller file.

I've changed that code like this (see the code below), and that issue is fixed.

if( $this->userIsLoggedIn ){
\TYPO3\CMS\Core\Utility\HttpUtility::redirect($this->redirectUrl);
}

Please check.

Actions #4

Updated by Claudia Höhne almost 11 years ago

Hi, I have the same problem, from "forgot password form" back to "login-form" (all same page) goes to ../login/?tx_felogin_pi1[forgot]=1

TYPO3 6.0.4
standard configuration
(deactivated my felogin TS for testing)

Actions #5

Updated by Franz Kugelmann almost 11 years ago

I can confirm this problem for 4.7.10 with standard configuration

Actions #6

Updated by Pascal Dürsteler almost 11 years ago

I can also confirm this, fresh setup of 4.7.10 with felogin 4.7.10.

Actions #7

Updated by Jigal van Hemert almost 11 years ago

  • Status changed from Needs Feedback to Accepted
  • Assignee set to Jigal van Hemert
  • Target version set to 4.7.11

Seems to go wrong in 4.7 and later. In 4.6 the link looks correct.

Actions #8

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20002

Actions #9

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/20350

Actions #10

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/20351

Actions #11

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/20352

Actions #12

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/20350

Actions #13

Updated by Jigal van Hemert almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #14

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/20352

Actions #15

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/20351

Actions #16

Updated by Jigal van Hemert almost 11 years ago

  • Status changed from Under Review to Resolved
Actions #17

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF